Footer updates partial fix for 171 #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janell-Huyck
requested changes
Sep 12, 2023
There was a problem hiding this comment.
Overall looks good. A couple of small tweaks:
The "Jobs" link is different. The correct link is: https://www.uc.edu/careers.html
The "News" and "Events Calendar" links on our site should end in ".html"
We need a link to "Free Speech" in the bottom section. The link on the main page is broken (like their links to Non-Discrimination and Privacy) because the link lacks ".html" at the end. The correct link is https://www.uc.edu/freespeech.html.
|
@haitzlm reminder to follow up on this PR next week. |
Janell-Huyck
force-pushed
the
footer-updates
branch
from
7ee22b6
to
8119d77
Compare
Janell-Huyck
requested review from
Janell-Huyck and
crowesn
and removed request for
Janell-Huyck
Janell-Huyck
approved these changes
Sep 19, 2023
|
Looks good, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #171