131 added tests for channels, jobs, and publications_helper #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janell-Huyck
changed the title
Janell-Huyck
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #131
Increase test coverage to over 95% per Coveralls.
The "channels" classes and jobs/applications_job didn't have any tests, as they were simply blank models. I was not 100% certain that we were not using these models somewhere or having the intent to use them in the future, so I made a couple of tests that simply checked if they were inheriting from the correct classes.
The helper "publications_helper" had a bunch of functions in it that didn't have any tests. Created a folder at spec/helpers/publications_helper/ and created a file for each function contained within the helper.
Rewrote the "create_citation" function to improve readability and added extra validation checks for author_citation and authors_array.