Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Webpacker. #213

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Removes Webpacker. #213

merged 1 commit into from
Sep 19, 2023

Conversation

scherztc
Copy link
Contributor

@scherztc scherztc commented Sep 18, 2023

This should transition us off of webpacker to jsbundle according to the transition guide : https://github.com/rails/jsbundling-rails/blob/main/docs/switch_from_webpacker.md

This also fixes the cap qa deploy problems.

Fixes #212
Fixes #214

Copy link
Contributor

@Janell-Huyck Janell-Huyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scherztc That's fantastic! I went ahead and test-deployed it on qa, and it deploys fine. It runs locally fine. I'd feel more comfortable if @crowesn or @hortongn took a peek at the PR before we merge it up, but it looks good to me. Thank you!!

@hortongn
Copy link
Member

@scherztc Nice fix! I don't have any requested changes, but two questions:

  1. This PR includes changes to scripts/start_qp.sh for the puma service. Is that intended to be merged or was that a temporary change? Is there another issue or PR already handling the service changes?

  2. Do we expect to need this fix in our other applications? Was it the updated webpacker causing the problem? I'm just seeing if we can anticipate when this will show up in our other apps.

@crowesn
Copy link
Contributor

crowesn commented Sep 19, 2023

@hortongn For your first question, after a quick review, I realized we didn't have an issue that touched directly on the puma daemon deprecation, I created one here: #214

@crowesn crowesn self-assigned this Sep 19, 2023
Copy link
Contributor

@crowesn crowesn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, merging.

@crowesn crowesn merged commit 03a2e68 into qa Sep 19, 2023
@crowesn crowesn deleted the fix/webpacker branch September 19, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update capistrano/deploy scripts for Puma daemon deprecation Unable to deploy QA branch
4 participants