Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add confirmation check to deploy #225

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Add confirmation check to deploy #225

merged 1 commit into from
Sep 29, 2023

Conversation

crowesn
Copy link
Contributor

@crowesn crowesn commented Sep 28, 2023

Fixes #218

Add general confirmation check for deploy on all modes and change request check on production deploys.

@crowesn crowesn force-pushed the 218/interactive-deploy-check branch 2 times, most recently from 3d10060 to 62a3265 Compare September 29, 2023 15:47
Janell-Huyck
Janell-Huyck approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@Janell-Huyck Janell-Huyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you've included notifications about the branch and stage for deployment. Also, thanks for including the ability to confirm with more than just "Y" :)

Looks good!

@Janell-Huyck Janell-Huyck merged commit 49e28ba into qa Sep 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Janell-Huyck Janell-Huyck Janell-Huyck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add interactive confirmation check for deploy
2 participants
@crowesn @Janell-Huyck