Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 1.56.3 to 1.56.4 #231

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 2, 2023

Bumps rubocop from 1.56.3 to 1.56.4.

Release notes

Sourced from rubocop's releases.

RuboCop 1.56.4

Bug fixes

  • #12221: Fix a false positive for Layout/EmptyLineAfterGuardClause when using return before guard condition with heredoc. (@​koic)
  • #12213: Fix a false positive for Lint/OrderedMagicComments when comment text # encoding: ISO-8859-1 is embedded within example code as source code comment. (@​koic)
  • #12205: Fix an error for Style/OperatorMethodCall when using foo bar./ baz. (@​koic)
  • #12208: Fix an incorrect autocorrect for the --disable-uncorrectable command line option when registering an offense is outside a percent array. (@​koic)
  • #12203: Fix an incorrect autocorrect for Lint/SafeNavigationChain when using safe navigation with comparison operator as an expression of logical operator or comparison operator's operand. (@​koic)
  • #12206: Fix an incorrect autocorrect for Style/OperatorMethodCall when using foo./bar. (@​koic)
  • #12202: Fix an incorrect autocorrect for Style/RedundantConditional when unless/else with boolean results. (@​ydah)
  • #12199: Fix false negatives for Layout/MultilineMethodCallIndentation when using safe navigation operator. (@​koic)

Changes

  • #12197: Make Style/CollectionMethods aware of collect_concat. (@​koic)
Changelog

Sourced from rubocop's changelog.

1.56.4 (2023-09-28)

Bug fixes

  • #12221: Fix a false positive for Layout/EmptyLineAfterGuardClause when using return before guard condition with heredoc. ([@​koic][])
  • #12213: Fix a false positive for Lint/OrderedMagicComments when comment text # encoding: ISO-8859-1 is embedded within example code as source code comment. ([@​koic][])
  • #12205: Fix an error for Style/OperatorMethodCall when using foo bar./ baz. ([@​koic][])
  • #12208: Fix an incorrect autocorrect for the --disable-uncorrectable command line option when registering an offense is outside a percent array. ([@​koic][])
  • #12203: Fix an incorrect autocorrect for Lint/SafeNavigationChain when using safe navigation with comparison operator as an expression of logical operator or comparison operator's operand. ([@​koic][])
  • #12206: Fix an incorrect autocorrect for Style/OperatorMethodCall when using foo./bar. ([@​koic][])
  • #12202: Fix an incorrect autocorrect for Style/RedundantConditional when unless/else with boolean results. ([@​ydah][])
  • #12199: Fix false negatives for Layout/MultilineMethodCallIndentation when using safe navigation operator. ([@​koic][])

Changes

  • #12197: Make Style/CollectionMethods aware of collect_concat. ([@​koic][])
Commits
  • fc57892 Cut 1.56.4
  • b7d99b8 Update Changelog
  • 0f55002 Merge pull request #12222 from koic/fix_a_false_positive_for_layout_empty_lin...
  • 59fb188 Merge pull request #12220 from koic/fix_an_incorrect_autocorrect_for_disable_...
  • 9b04830 [Fix #12221] Fix a false positive for Layout/EmptyLineAfterGuardClause
  • d0d612e [Fix #12208] Fix an incorrect autocorrect for the --disable-uncorrectable o...
  • c626229 Merge pull request #12218 from koic/fix_a_false_positive_for_lint_ordered_mag...
  • a2c1100 [Fix #12213] Fix a false positive for Lint/OrderedMagicComments
  • 3e92160 Disable RSpec/FilePath to resolve build error
  • 1e43822 Merge pull request #12215 from koic/update_the_doc_of_style_return_nil
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.56.3 to 1.56.4.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.56.3...v1.56.4)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Oct 2, 2023
@Janell-Huyck Janell-Huyck self-assigned this Oct 2, 2023
Copy link
Contributor

@Janell-Huyck Janell-Huyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Deploys. No issues.

@Janell-Huyck Janell-Huyck merged commit 96eb52f into qa Oct 2, 2023
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-1.56.4 branch October 2, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant