-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
249 - Fix invalid access token error #261
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janell-Huyck
changed the title
WIP 249 invalid access token fix
249 invalid access token fix
Oct 19, 2023
Janell-Huyck
changed the title
249 invalid access token fix
WIP 249 invalid access token fix
Nov 14, 2023
Janell-Huyck
force-pushed
the
249-handle-invalid-authenticity-token-errors
branch
from
November 16, 2023 18:45
bfde778
to
92d7a4a
Compare
Janell-Huyck
changed the title
WIP 249 invalid access token fix
249 - Fix invalid access token error
Nov 16, 2023
Janell-Huyck
force-pushed
the
249-handle-invalid-authenticity-token-errors
branch
from
December 1, 2023 16:01
26e118f
to
0fc0888
Compare
Janell-Huyck
changed the title
249 - Fix invalid access token error
WIP *** 249 - Fix invalid access token error
Dec 1, 2023
Janell-Huyck
force-pushed
the
249-handle-invalid-authenticity-token-errors
branch
from
December 6, 2023 22:42
9fd404e
to
8597cce
Compare
Janell-Huyck
changed the title
WIP *** 249 - Fix invalid access token error
249 - Fix invalid access token error
Dec 6, 2023
crowesn
reviewed
Jan 23, 2024
@@ -77,6 +77,8 @@ | |||
|
|||
def create_submitter(submitter) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not directly related to this PR, but wondering if this function might find a better home in /spec/support.
crowesn
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a dense PR, good work, merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #249
This PR creates another controller "concern", ExceptionHandlingManager, to take care of the InvalidAuthenticityToken error and to collect other custom error handling created in the future.
It is called inside the application_controller and does the following:
Tests:
Unit tests: spec/controllers/concerns/exception_handling_manager_spec.rb
Feature tests: I created a series of tests to address how the application should or should not be able to be accessed in combinations of the following issues:
This series of tests is why I marked this PR as "large". They are in the folder: spec/features/application_access/
Additional changes