285 - Refactor PublicationsController#index #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janell-Huyck
changed the title
Janell-Huyck
force-pushed
the
refactor-285-publications-controller-index-refactor
branch
from
b52ac63
to
066de30
Compare
Janell-Huyck
force-pushed
the
refactor-285-publications-controller-index-refactor
branch
from
066de30
to
db63adc
Compare
Janell-Huyck
force-pushed
the
refactor-285-publications-controller-index-refactor
branch
2 times, most recently
from
8e21876
to
40cf1d7
Compare
Janell-Huyck
force-pushed
the
refactor-285-publications-controller-index-refactor
branch
from
40cf1d7
to
e065cf2
Compare
haitzlm
approved these changes
Mar 12, 2024
Janell-Huyck
deleted the
refactor-285-publications-controller-index-refactor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #285
Ref #87 - this should be the last refactor currently needed for PublicationsController.
Index method is now more readable. Same output given, so tests remain unchanged.