333 - Remove Docker from app but not CI #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #333
This PR removes the Docker code related to the app.
We are not using Docker to run locally or in production, but CI is using Docker to spin up the app during deployments.
The CI relies on the file .circleci/config.yml to tell it what Docker image to use, but our config file does not directly use the "docker-compose" commands which would use the .dockerignore and docker-compose.yml files.
Following best-practice of removing dead and unused code (rather than trying to keep it up to date), this PR:
Removes the following files:
Modifies
.github/dependabot.ymlto stop instructing dependabot to look for updates in the Docker files.