Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pagy from 6.4.3 to 7.0.2 #371

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 19, 2024

Bumps pagy from 6.4.3 to 7.0.2.

Release notes

Sourced from pagy's releases.

v7.0.0

✴ What's new ✴

Changelog

Sourced from pagy's changelog.

Version 7.0.2

  • Fix for missing to fetch count_args default (close #645)
  • Non-code improvements

Version 7.0.1

  • Updates ckb translations to be complaint with ARIA in v7.x.x (#643)

Version 7.0.0

Breaking changes

  • Dropped old rubies support: Pagy follows the ruby end-of-life supported rubies now.
  • Renamed :i18n_key > :item_i18n_key
  • Refactored support extra
    • Renamed pagy_prev_link to pagy_prev_html to avoid confusion with pagy_prev_link_tag
    • Removed pagy_next_link to pagy_next_html to avoid confusion with pagy_next_link_tag
  • Rack 3 breaking changes:
    • The headers extra produces all lowercase headers, regardless how you set them see rack issue
    • Removed :escaped_html option from pagy_url_for (only breaking if you override the method or use the option directly)
  • Dictionary structure changes: (affects only app with custom helper/templates/dictionary entries)
    • The nav entry has been flattened: pagy.nav.* entries are now pagy.*:
      • If you have custom helpers/templates: search the keys that contain '.nav.' and replace them with '.'
      • If you have custom dictionary entries (overrides): remove the 'nav:' line and unindent its block
    • A few labels used as aria-label have been added: you may want to add/use them to your custom helper/templates/dictionaries for ARIA compliance.
      • pagy.aria_label.nav Pluralized entry: used in the nav element
      • pagy.aria_label.prev, pagy.aria_label.next Single entry: used in the prev/next a link elements

Default changes (possibly breaking test/views)

  • Changed Pagy::DEFAULT[:size] variable defaults from [1, 4, 4, 1] to 7. You can explicitly set/restore it in the initializer, if your app was relying on it.
  • Added sensible :size defaults in Calendar Unit subclasses. You can explicitly set it in the initializer, if your app was relying on it.
    • Pagy::Calendar::Day::DEFAULT[:size] 31
    • Pagy::Calendar::Month::DEFAULT[:size] 12
    • Pagy::Calendar::Quarter::DEFAULT[:size] 4
    • Pagy::Calendar::Year::DEFAULT[:size] 10
  • Changed a few format defaults in Calendar Unit subclasses. You can explicitly set it in the initializer, if your app was relying on it.
    • Pagy::Calendar::Day::DEFAULT[:format] from '%Y-%m-%d' to '%d'
    • Pagy::Calendar::Month::DEFAULT[:format] from '%Y-%m' to '%b'
    • Pagy::Calendar::Quartr::DEFAULT[:format] from '%Y-Q%q' to 'Q%q'

Visual changes (possibly breaking test/views)

  • The ARIA label compliance required the refactoring of all the nav helper that might look slightly different now.

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Feb 19, 2024
Bumps [pagy](https://github.com/ddnexus/pagy) from 6.4.3 to 7.0.2.
- [Release notes](https://github.com/ddnexus/pagy/releases)
- [Changelog](https://github.com/ddnexus/pagy/blob/master/CHANGELOG.md)
- [Commits](ddnexus/pagy@6.4.3...7.0.2)

---
updated-dependencies:
- dependency-name: pagy
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Copy link
Contributor

@Janell-Huyck Janell-Huyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passing and it still paginates items on index page for admins

@Janell-Huyck Janell-Huyck merged commit 63712cf into qa Feb 21, 2024
2 checks passed
@dependabot dependabot bot deleted the dependabot/bundler/pagy-7.0.2 branch February 21, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant