305 - UI fixes to add author partial #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janell-Huyck
force-pushed
the
305/ui-fixes-to-add-author-partial
branch
from
14f7eb9
to
0d72e35
Compare
Janell-Huyck
changed the title
Janell-Huyck
force-pushed
the
305/ui-fixes-to-add-author-partial
branch
from
0d72e35
to
6458d93
Compare
haitzlm
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #305
This PR sets the addAuthor partial to display in a responsive format, showing one column for phones, two columns (delete button below inputs) for tablets, and three columns (the delete button to the right of inputs) for desktop views.
Testing for the form layout was updated and refactored to apply to both the submitter form and the addAuthor form.
Form layout classes in submitter form were updated to reflect the expansion of the layout styling.
<html lang="en">was inserted at the top of the application.js file as an accessibility item.A function that should have been public was accidentally placed in a private section, resulting in some flaky tests. Moved it back into the public section.
When firing this up locally, you should be able to adjust the size of the browser window to phone, tablet, and desktop sizes and see a smooth transition in layouts. Items should look aligned with each other and not crowd in the page.