Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

243 - Update finished page #387

Merged
merged 3 commits into from
Mar 12, 2024
Merged

243 - Update finished page #387

merged 3 commits into from
Mar 12, 2024

Conversation

Janell-Huyck
Copy link
Contributor

@Janell-Huyck Janell-Huyck commented Mar 7, 2024

Fixes #243

This PR adds two pieces to the Logged-Out page:

  1. A link to Scholar
  2. A link back to the Submitter page (login page)

Things to check:

  1. Link to Melissa's email goes to the correct address
  2. Scholar link opens a new tab going to scholar
  3. Return to Submitter page does not open new tab, returns to the login page
  4. Any typo's
  5. New accessibility issues (Known issue: missing "language" from page, addressed in another PR)

Old version:
Screenshot 2024-03-07 at 2 25 36 PM

New version:
Screenshot 2024-03-07 at 2 25 07 PM

@Janell-Huyck Janell-Huyck changed the title WIP -Update finished page 243 - Update finished page Mar 7, 2024
@haitzlm haitzlm self-assigned this Mar 7, 2024
Copy link
Contributor

@haitzlm haitzlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and matches the screen shot. One teeny tiny suggestion, add an "external link" icon next to the scholar link.
https://iconduck.com/icons/84989/external-link

@haitzlm haitzlm merged commit e969f39 into qa Mar 12, 2024
2 checks passed
@Janell-Huyck Janell-Huyck deleted the 243-thank-you-page-dead-end branch April 16, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thank You page is a dead end
2 participants