-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
402 - Update footer to match library footer #403
Conversation
@haitzlm I'd like you to review this next week. |
will do
Lisa Haitz
Developer
UC Libraries
…________________________________
From: Glen Horton ***@***.***>
Sent: Friday, March 15, 2024 9:37:31 AM
To: uclibs/aaec ***@***.***>
Cc: Haitz, Lisa (haitzlm) ***@***.***>; Mention ***@***.***>
Subject: Re: [uclibs/aaec] 402 - Update footer to match library footer (PR #403)
External Email: Use Caution
@haitzlm<https://github.com/haitzlm> I'd like you to review this next week.
—
Reply to this email directly, view it on GitHub<#403 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AADYQVWJKCVB4LYAPBD3V3TYYL2RXAVCNFSM6AAAAABEW4KXRSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJZGY4DGNJYGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The links on this are all correct. However, there should be no underlines for an state of the footer links (a:active, a:visited, etc...)) . I see the lines on both local and deployed version.
See my comment re underlines on links |
I see on the main website that the very bottom links, while underlined, become not-underlined on hover, and the main lines, while not-underlined, become underlined on hover. Fixing this now. If you meant something else please clarify. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is correct for underlines...which was the only issue I had.
Fixes #402
Updates footer to more closely match the UC Library footer.