Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

402 - Update footer to match library footer #403

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

Janell-Huyck
Copy link
Contributor

Fixes #402

Updates footer to more closely match the UC Library footer.

  • Adds "Bearcat Portal" link
  • Updates copywrite year to 2024
  • Makes layout mobile-friendly and responsive
  • Removes underlines from resources links to match the library site

@hortongn
Copy link
Member

@haitzlm I'd like you to review this next week.

@haitzlm
Copy link
Contributor

haitzlm commented Mar 15, 2024 via email

Copy link
Contributor

@haitzlm haitzlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The links on this are all correct. However, there should be no underlines for an state of the footer links (a:active, a:visited, etc...)) . I see the lines on both local and deployed version.

@haitzlm
Copy link
Contributor

haitzlm commented Mar 22, 2024

See my comment re underlines on links

@Janell-Huyck
Copy link
Contributor Author

Janell-Huyck commented Mar 26, 2024

I see on the main website that the very bottom links, while underlined, become not-underlined on hover, and the main lines, while not-underlined, become underlined on hover. Fixing this now. If you meant something else please clarify.

Copy link
Contributor

@haitzlm haitzlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is correct for underlines...which was the only issue I had.

@haitzlm haitzlm merged commit 3914169 into qa Apr 2, 2024
2 checks passed
@Janell-Huyck Janell-Huyck deleted the 402-update-footer branch April 16, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer update to match Libraries footer
3 participants