-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be able to bind statefulsets to the host network #51
base: master
Are you sure you want to change the base?
Conversation
…when you need to access from outside k8s without a proxy)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@angel9484 Thanks for your interest on the redis-cluster-operator!
The redis exporter container also need to set the port HostPort.
is it possible choose different port for redis deployment. we are planning to use multiple redis clusters and setting host network true requires lot of nodes. So, we are planning to choose different port for each redis cluster. |
that's a great idea!, I had no time to finish this PR but my company liked your suggestion so I will try to work on this asap 👍 |
gotcha! I hope to work on this soon :) |
@polefishu why to expose the exporter with a host port? in this case if you have a collector that get metrics and push it to (per example) prometheus, I can do it but i think for the case of the exporter is not needed, what do you think? Thanks!! |
set port to use in redis-server run
…nd_gossip_in_redis make configurable the port in all places.
@sravyav I've updated this PR to include the posibility to configure a port in the CR. |
@angel9484 Thanks for the contribution. If we create a cluster with 3 masters and 3 slaves, this limitation requires us to distribute each redis to a different kubernetes nodes, this means we need at least 6 kubernetes nodes with free resources. |
Exporter and redis share the same network namespace. |
@angel9484 is there any way we can connect to redis cluster exposing externally? we tried creating type LoadBalancer on service and trying to reach redis cluster from outside k8s cluster. Problem is it's connecting to lb and while adding the key its redirecting pod IP and saying it cant reachable because of this we can't achieve redis accessing externally. Any thoughts on how to fix it pls? |
Hi @polefishu ! Thanks! |
…nd_gossip_in_redis configure more port options and monitor port in hostnetwork with hostport
…urable_port_and_gossip_in_redis # Conflicts: # pkg/apis/redis/v1alpha1/distributedrediscluster_types.go # pkg/resources/services/service.go
…nd_gossip_in_redis Feature/make configurable port and gossip in redis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finished merging
Hi @salla2 |
…nd_gossip_in_redis Feature/make configurable port and gossip in redis
…nd_gossip_in_redis delete again check of min number of replicas as original code has
Hi,Why hasn't this PR been merged for so long? |
…ckup_and_restore use directly osm
Why hasn't this PR been merged? @polefishu @angel9484 @fabrinator |
when the client is outside of kubernetes cluster and you cannot put a proxy between client and redis-cluster-operator we needed to change code to bind the stateful to host dedicated nodes.
This change make it configurable