Feature/auto restart for update #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/k8sutil/statefulset.go
Outdated
Comment on lines
46
to
52
| origss, err := s.GetStatefulSet(ss.Namespace, ss.Name) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| patch := client.MergeFrom(origss.DeepCopy()) | ||
| ss.Spec.Template.DeepCopyInto(&origss.Spec.Template) | ||
| return s.client.Patch(context.TODO(), origss, patch) |
There was a problem hiding this comment.
Hi @debbyku,
With this change I was able to restart pods during resource updates, but the change of the number of replicas is not working anymore. Can you confirm it?
Thanks!!!
There was a problem hiding this comment.
Sorry, I missed the replicas update here as the "replicas" is not in ss.Spec.Template.
I've modified the codes and and push again.
Thanks.
|
why it is not merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is to provide auto restart feature when updating redis cluster features, e.g. cpu, memory, image.
It will also update pvc storage size.