Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Openjpeg 2.2.0 always build shared library even though -DBUILD_SHARED_LIBS:bool=off #1019

Closed
xanadu6291 opened this issue Sep 17, 2017 · 4 comments
Closed

Openjpeg 2.2.0 always build shared library even though -DBUILD_SHARED_LIBS:bool=off #1019

xanadu6291 opened this issue Sep 17, 2017 · 4 comments

Comments

@xanadu6291
Copy link

Openjpeg 2.2.0 always build shared library even though -DBUILD_SHARED_LIBS:bool=off

Version 2.1.2 is OK. Is it a bug?
rouault added a commit that referenced this issue Sep 17, 2017
@rouault
Build: make sure that -DBUILD_SHARED_LIBS:bool=off is honoured to bui…
3dfc6ca 
…ld only the static lib (#1019)
@rouault
Copy link
Collaborator

rouault commented Sep 17, 2017

. Is it a bug?

Yes, should be fixed per 3dfc6ca

@rouault rouault closed this as completed Sep 17, 2017
@pwaller
Copy link

pwaller commented Oct 9, 2017

@rouault

Is there a logic bug in 3dfc6ca? I find that if -DBUILD_SHARED_LIBS:bool=off is specified, then the static library does not get installed to $PREFIX/lib. (It did get installed prior to 3dfc6ca - that commit appears to have broken our build)

rouault added a commit that referenced this issue Oct 9, 2017
@rouault
Unix build: fix regression of 2.3.0 where a shared-only or static-onl…
66297f0 
…y build lacks the installation target for the library (#1019, fixes regression introduced by 3dfc6ca)
@rouault
Copy link
Collaborator

rouault commented Oct 9, 2017

@pwaller Indeed. Just fixed it. I probably only tested the "make" target and not the "make install" target.

@pwaller
Copy link

pwaller commented Oct 9, 2017

Confirmed it fixes our build 👍. A fantastically speedy fix from your side, thanks! 🥇

@rouault rouault mentioned this issue Oct 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pwaller @rouault @xanadu6291