Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OpenJPEG] PNG codec for OpenJPEG_v1_3 #16

Closed
gcode-importer opened this issue Mar 10, 2010 · 4 comments
Closed

[OpenJPEG] PNG codec for OpenJPEG_v1_3 #16

gcode-importer opened this issue Mar 10, 2010 · 4 comments
Labels
bug gcode_fixed OpSys-Windows Priority-High

Comments

@gcode-importer
Copy link

Originally reported on Google Code with ID 16

To:openjpeg@googlegroups.com
Subject:[OpenJPEG] PNG codec for OpenJPEG_v1_3

This could have been the final version for OpenJPEG_v1_3. But the
'tiled image' case and other cases are unsolved.

This codec has been tested with bit_depth: 16, 8, 4, 2; with/without
alpha transparency; with color/gray. In both directions: 
PNG --> J2K --> reversePNG .

READ:
=====
16 Bit and parameters->cp_cinema are not used: I do not know what
cp_cinema is.

1,2,4 Bits are expanded to 8 Bits: I do not know whether the library
accepts these depths.


READ/WRITE:
===========
Time and Text are not used: I do not know whether the library accepts
Time/Text.


If this version should be accepted, I could write the codec for
OpenJPEG_v2.

winfried

Reported by szukw000 on 2010-03-10 17:48:33

- _Attachment: [PNG_codec_v1.c.7z](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-16/comment-0/PNG_codec_v1.c.7z)_
@gcode-importer
Copy link
Author 

Thanks Winfried for this patch. I committed it (rev554) but still have problems to 
make it functional under windows. Currently, an error message will show under WIN32

if you try to (de)compress PNG files.

I tried compiling a libpng static library as we did for libtif, but I can't seem to

have a working compilation. I have linking problems, and libtif and libpng libraries

don't seem to be happy together.

Experts are welcome ;-)

Reported by fodevaux on 2010-03-26 15:51:04

  • Labels added: Priority-High, OpSys-Windows
  • Labels removed: Priority-Medium

@gcode-importer
Copy link
Author

Reported by fodevaux on 2010-04-08 18:30:42

  • Status changed: Started

@gcode-importer
Copy link
Author 

Hi 
With current trunk and opj-1.5 version, the build of png and tiff lib seems to be correctly
handle.

We should closed this issue.

Best
Mickael

Reported by savmickael on 2011-11-02 14:17:55

@gcode-importer
Copy link
Author 

Ok. Closing then.

Reported by malaterre on 2012-02-10 10:35:43

  • Status changed: Fixed

@gcode-importer gcode-importer self-assigned this Jun 11, 2015
develone added a commit to develone/openjpeg that referenced this issue Mar 22, 2017
@develone
commented /*#define OPJ_HAVE_POSIX_MEMALIGN bare-metal for ultibo*/
ec031cf 
ultibo was having issues with
pi@raspberrypi3:~/jpeg-2000-test/bare-metal/openjp $ ./compile.sh
dwtlift.c:(.text+0x694): undefined reference to `lifting'
libdwtlift.a(opj_malloc.o): In function `opj_aligned_malloc':
opj_malloc.c:(.text+0x40): undefined reference to `posix_memalign'
libdwtlift.a(opj_malloc.o): In function `opj_aligned_realloc':
opj_malloc.c:(.text+0x98): undefined reference to `posix_memalign'
DWT_LIFT_RPi2.lpr(153,98) Error: Error while linking
DWT_LIFT_RPi2.lpr(153,98) Fatal: There were 1 errors compiling module, stopping
Fatal: Compilation aborted
Error: /home/pi/ultibo/core/fpc/bin/ppcarm returned an error exitcode
ls: cannot access kernel7.img: No such file or directory
-rw-r--r-- 1 pi pi   6344 Mar 21 18:41 dwtlift.o
-rw-r--r-- 1 pi pi 330354 Mar 21 18:41 libdwtlift.a
-rw-r--r-- 1 pi pi 330354 Mar 21 18:41 libopenjp2.a

00000024 <opj_aligned_malloc>:
  24:   e2501000        subs    r1, r0, #0
  28:   012fff1e        bxeq    lr
  2c:   e3a00010        mov     r0, uclouvain#16
  30:   eafffffe        b       0 <memalign>

00000034 <opj_aligned_realloc>:
  34:   e92d4070        push    {r4, r5, r6, lr}
  38:   e2515000        subs    r5, r1, #0
  3c:   0a000004        beq     54 <opj_aligned_realloc+0x20>
  40:   ebfffffe        bl      0 <realloc>
  44:   e310000f        tst     r0, uclouvain#15
  48:   e1a04000        mov     r4, r0
  4c:   1a000002        bne     5c <opj_aligned_realloc+0x28>
  50:   e8bd8070        pop     {r4, r5, r6, pc}
  54:   e1a00005        mov     r0, r5
  58:   e8bd8070        pop     {r4, r5, r6, pc}
  5c:   e3a00010        mov     r0, uclouvain#16
  60:   e1a01005        mov     r1, r5
  64:   ebfffffe        bl      0 <memalign>
  68:   e2506000        subs    r6, r0, #0
@Google-Autofuzz Google-Autofuzz mentioned this issue May 23, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug gcode_fixed OpSys-Windows Priority-High
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@detonin @gcode-importer