Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert.c is unmaintainable #264

Open
gcode-importer opened this issue Feb 28, 2014 · 3 comments
Open

convert.c is unmaintainable #264

gcode-importer opened this issue Feb 28, 2014 · 3 comments
Assignees

Comments

@gcode-importer
Copy link

Originally reported on Google Code with ID 264

Just look at convert.c to be convinced. For example have a look at issue #171 and in
particular the patch needed to clamp value returned from openjpeg. All formats are
affected by the issue.

This means that we could have our test suite be valid for PGX output, but invalid for
other, this feel really unconfortable.

Reported by malaterre on 2014-02-28 08:38:42

@gcode-importer
Copy link
Author

I think convert.c should support pgx, raw, tiff and png. Its used only for test suite
and give example through applications.

Reported by savmickael on 2014-03-06 11:54:46

@gcode-importer
Copy link
Author

I think that convert.c needs to be split.
IMHO, there shall be one file per image format with one helper file which deals with
component bit depth limitations, component transform (e.g. from transform one line
from opj_image to 8bpp interleaved RGB with clamping etc...)

We can see that all imagetoxxx share a great deal of code. The minimum effort needed
is to get this code merged in helper functions that are used consistently throughout
those imagetoxxx functions.

Reported by mayeut on 2014-10-16 22:05:50

@gcode-importer
Copy link
Author

I started to split it starting at r2972 to get Issue 203 a bump.

Reported by mayeut on 2014-12-20 18:51:32

@gcode-importer gcode-importer self-assigned this Jun 11, 2015
mayeut added a commit to mayeut/openjpeg that referenced this issue Jul 14, 2015
mayeut added a commit to mayeut/openjpeg that referenced this issue Jul 15, 2015
mayeut added a commit to mayeut/openjpeg that referenced this issue Jul 19, 2015
Only input modified for now
Update uclouvain#536
Update uclouvain#264
mayeut added a commit to mayeut/openjpeg that referenced this issue Jul 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant