Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor changes, clean-up #349

Closed
gcode-importer opened this issue May 15, 2014 · 1 comment
Closed

minor changes, clean-up #349

gcode-importer opened this issue May 15, 2014 · 1 comment

Comments

@gcode-importer
Copy link

Originally reported on Google Code with ID 349

From https://code.google.com/p/sumatrapdf/source/browse/trunk/ext/_patches/openjpeg.patch?spec=svn8835&r=8834
:

* Replace magic number 32 in j2k.c@3167 with ABI-change-proof calculation |sizeof(l_tcp->pocs)
/ sizeof(l_tcp->pocs[0])|.

* Replace stdin-spamming printf in t2.c@866 with fprintf(stderr, ...) or remove it
altogether in t2.c@870.

* Reset l_cblk->data in t2.c@1161 so that it isn't accidentally double-freed later
on.

* Also, apparently MSVC debug CRT's memory manager asserts even for (size_t)-0x100
and the actual maximum allocation size is 0x7ffdefff for opj_malloc.h (three times).

Reported by zeniko on 2014-05-15 20:59:20

@rouault
Copy link
Collaborator

rouault commented Sep 19, 2017

I only took into account the suggestion related to the max number of POCs. Can't make sense of other ones with current code, or already taken into account since.

@rouault rouault closed this as completed Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants