Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiple potential vulnerabilities such as division-by-zero, heap-based buffer overflow and etc. #1139

Closed
wants to merge 13 commits into from

Conversation

YangY-Xiao
Copy link

To avoid divisions by zero / undefined behaviour on shift.

@YangY-Xiao YangY-Xiao changed the title To avoid divisions by zero / undefined behaviour on shift fix multiple potential vulnerabilities such as division-by-zero, heap-based buffer overflow and etc. Aug 30, 2018
@rouault
Copy link
Collaborator

rouault commented Sep 22, 2018

Would you mind rewording the commit message by prefixing them with "[JPWL] " so that it is clear which component is affected ?

@YangY-Xiao
Copy link
Author

@rouault
done!

@rouault
Copy link
Collaborator

rouault commented Sep 26, 2018

There's an indentation issue. See https://travis-ci.org/uclouvain/openjpeg/jobs/433451076 . Use scripts/prepare_commit.sh to fix it

@rouault
Copy link
Collaborator

rouault commented Sep 26, 2018

can you integrate the indentation fix into the appropriate commit so as to have a clean history ?

@rouault
Copy link
Collaborator

rouault commented Oct 18, 2018

@Young-X I'm confused by the history of this branch. Could you rebase on top of master, and try to clean it a bit ?

@YangY-Xiao
Copy link
Author

I made a new pr #1168.

@YangY-Xiao YangY-Xiao closed this Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants