Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build meson support #1242

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dabrain34
Copy link

@dabrain34 dabrain34 commented Apr 6, 2020

Openjpeg is used by GStreamer to support jpeg2000 and as gst-build provides a very easy way to build gstreamer and its depencies using Meson, here is a bunch of commits to add this support, without any changes to the existing CMake build system.

@rouault
Copy link
Collaborator

rouault commented Apr 6, 2020

I'm not sure we want to add a second build system into the library...

@dabrain34
Copy link
Author

Sorry I realized that I did not add much to my PR description.

My idea with this PR was to provide the possibility to use openjpeg as a subproject of another meson project (gst-build).
I can understand that you dont want to maintain multiple buildsystem.

But as you can see, I did not touch anything in CMake and we can have also the power and flexiility of the trendy Meson.

@rouault
Copy link
Collaborator

rouault commented Apr 6, 2020

openjpeg is insufficiently maintained (by me in particular :-)), so adding more stuff that could rot easily (as I won't use it personnally) is not super compelling.

You might want to raise the issue on the openjpeg mailing list and see if it raises interest from other stakeholders.

by the way the change in libtiff should likely be reverted. libtiff has an upstream (https://gitlab.com/libtiff/libtiff), and openjpeg should not modify it, unless resynchronizing with that upstream

@dabrain34
Copy link
Author

No problem I will drop the indent commit in libtiff.

I understand your point regarding the support of 2 build system :)

I just wanted to let you know first of the existence of this port.

@dabrain34 dabrain34 force-pushed the build_meson_support branch 2 times, most recently from 03f119e to 2892884 Compare April 14, 2020 09:46
Build support:
- thirdparties(z, tiff, png, cms2)
- jp2
- jpip
- jpwl
- mj2
- jp3d
Stéphane Cerveau added 2 commits September 29, 2020 13:07
@xclaesse
Copy link

Porting openjpeg to Meson would allow to delete the thirdparty directory completely. Meson has a subproject mechanism made exactly for that use-case. zlib, png, tiff are already available in meson ports (wrapdb) and lcms2 could easily be added too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants