-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for high throughput (HTJ2K) decoding. #1381
Conversation
2c29092
to
76a91ae
Compare
@aous72 Does the PR text / commit message captures well the (known) limitations of the implementation ? |
@rouault
All the points are correct. Perhaps, I would replace "only up to 3 coding passes are supported" with:
The singleHT set can have up to 3 passes. Feel free to modify the text. Thank you. |
76a91ae
to
c1cd93a
Compare
There are a few limitations: - mixed mode (HT and regular code blocks) is not supported. - ROI in HT blocks is not supported. - Placeholder passes are not supported. - MultiHT sets are not support, only a singleHT set. - there are known issues with some compliance testing files related to the parsing of packet header.
c1cd93a
to
f3d8c76
Compare
@rouault A second question: If I want to do more development, what should I do? clone it again? |
Travis-CI has a s390x big endian target but given their new economic model, it is impractical for open source projects if you don't subscribe to their service. Otherwise if you don't have access to a big endian box, you can potentially use qemu full system emulation with a big endian emulated machine (will be rather slow). Honestly, I wouldn't put too much effort on that given the very very low market share of big endian nowadays. Efforts on improving compliance and speed would be much better time investment.
no, normally, you would just do
but as your working branch was master (not recomended practice), you perhaps need to do something along
I'm assuming your |
Thank you for your detailed explanation. |
You can request access to a POWER machine here: As mentionned by @rouault this should not be a top priority anyway. |
@malaterre Very useful suggestion. Thank you. |
- Update from version 2.4.0 to 2.5.0 - Update of rootfile - Changelog 2.5.0 (May 2022) No API/ABI break compared to v2.4.0, but additional symbols for subset of components decoding (hence the MINOR version bump). * Encoder: add support for generation of TLM markers [\#1359] (uclouvain/openjpeg#1359) * Decoder: add support for high throughput \(HTJ2K\) decoding. [\#1381] (uclouvain/openjpeg#1381) * Decoder: add support for partial bitstream decoding [\#1407] (uclouvain/openjpeg#1407) * Bug fixes (including security fixes) Signed-off-by: Adolf Belka <adolf.belka@ipfire.org> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
There are a few limitations:
the parsing of packet header
Continuation of #1374, which is a work by @aous72