Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UBSan gcc warning for first arg to memset non null #767

Merged
merged 1 commit into from
May 2, 2016
Merged

Fix UBSan gcc warning for first arg to memset non null #767

merged 1 commit into from
May 2, 2016

Conversation

julienmalik
Copy link
Collaborator

No description provided.

@julienmalik
Copy link
Collaborator Author

I manually checked that the NULL case was when w=1 and h=0, so we were actually memsetting zero bytes.

Maybe this should be detected earlier ?

@julienmalik
Copy link
Collaborator Author

Updates #718

@julienmalik julienmalik merged commit ba0cf12 into uclouvain:master May 2, 2016
@julienmalik
Copy link
Collaborator Author

Only 5 UB left on gcc 5.2 : http://my.cdash.org/viewDynamicAnalysis.php?buildid=953384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienmalik @detonin