-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using CTEST_USE_LAUNCHERS even when tests are disabled #772
base: master
Are you sure you want to change the base?
Conversation
Since cmake >= 3.0, using CTEST_USE_LAUNCHERS requires include(CTestUseLaunchers), which is automatically done by include(CTest) Setting CTEST_USE_LAUNCHERS in the cache without including CTest later triggers a configuration error : CMake Error: CTEST_USE_LAUNCHERS is enabled, but the RULE_LAUNCH_COMPILE global property is not defined. Did you forget to include(CTest) in the toplevel CMakeLists.txt ? CTEST_USE_LAUNCHERS was silently ignored in cmake <= 2.8 when not including CTest Include CTestUseLaunchers always, so that CTEST_USE_LAUNCHERS can be used even when not including CTest (for example for MinGW builds). This helps presenting the build errors and warnings more cleanly on the Dashboard.
Hum... quite strange that the mingw warnings disappear with ctest launchers enabled. This should be investigated further. |
CTEST_USE_LAUNCHERS is even ignored for this mingw build since it uses ctest 2.8, which ignores CTEST_USE_LAUNCHERS since include(CTest) is not used. We need cmake >= 3.0 here |
With cmake 3.5 it gets better : http://my.cdash.org/viewBuildError.php?type=1&buildid=953977 |
@mayeut ok for merging ? might want to still have a cmake 2.8 build around though (I see that appveyor also uses cmake 3.5)... |
If I understand correctly, there's no more build using cmake 2.8.x.
It would be good to keep at least one building with cmake 2.8.x. (e.g. I used a feature from cmake 3.x in a PR and didn't realize it until CI checks failed). |
Since cmake >= 3.0, using CTEST_USE_LAUNCHERS requires include(CTestUseLaunchers),
which is automatically done by include(CTest)
Setting CTEST_USE_LAUNCHERS in the cache without including CTest later
triggers a configuration error :
CMake Error: CTEST_USE_LAUNCHERS is enabled, but the RULE_LAUNCH_COMPILE
global property is not defined.
Did you forget to include(CTest) in the toplevel CMakeLists.txt ?
CTEST_USE_LAUNCHERS was silently ignored in cmake <= 2.8 when not including CTest
Include CTestUseLaunchers always, so that CTEST_USE_LAUNCHERS can be used even when not
including CTest (for example for MinGW builds).
This helps presenting the build errors and warnings more cleanly on the Dashboard.