Merge branch 'Feature-Issue-379' into unstable

ucoProject · Aug 19, 2022 · fa3da83 · fa3da83
2 parents 205412f + 8b84c5d
commit fa3da83
Show file tree

Hide file tree

Showing 7 changed files with 182 additions and 1 deletion.
diff --git a/ontology/uco/core/core.ttl b/ontology/uco/core/core.ttl
@@ -475,12 +475,38 @@ core:externalReference
 	.
 
 core:hasFacet
-	a owl:ObjectProperty ;
+	a
+		owl:ObjectProperty ,
+		owl:InverseFunctionalProperty
+		;
 	rdfs:label "hasFacet"@en ;
 	rdfs:comment "Further sets of properties characterizing a concept based on the particular context of the class and of the particular instance of the concept being characterized."@en ;
 	rdfs:range core:Facet ;
 	.
 
+core:hasFacet-shape
+	a sh:PropertyShape ;
+	sh:path core:hasFacet ;
+	sh:sparql [
+		a sh:SPARQLConstraint ;
+		sh:message "hasFacet must not be used to link two objects to one Facet."@en ;
+		sh:select """
+			PREFIX core: <https://ontology.unifiedcyberontology.org/uco/core/>
+			PREFIX owl: <http://www.w3.org/2002/07/owl#>
+			SELECT $this ?value
+			WHERE {
+				?value core:hasFacet $this .
+				?nOtherValue core:hasFacet $this .
+				FILTER ( ?value != ?nOtherValue )
+				FILTER NOT EXISTS {
+					?value owl:sameAs|^owl:sameAs ?nOtherValue .
+				}
+			}
+			""" ;
+	] ;
+	sh:targetObjectsOf core:hasFacet ;
+	.
+
 core:isDirectional
 	a owl:DatatypeProperty ;
 	rdfs:label "isDirectional"@en ;

diff --git a/tests/examples/Makefile b/tests/examples/Makefile
@@ -25,6 +25,8 @@ all: \
   co_XFAIL_validation.ttl \
   configuration_setting_PASS_validation.ttl \
   configuration_setting_XFAIL_validation.ttl \
+  has_facet_inverse_functional_PASS_validation.ttl \
+  has_facet_inverse_functional_XFAIL_validation.ttl \
   hash_PASS_validation.ttl \
   hash_XFAIL_validation.ttl \
   location_PASS_validation.ttl \
@@ -91,6 +93,8 @@ check: \
   co_XFAIL_validation.ttl \
   configuration_setting_PASS_validation.ttl \
   configuration_setting_XFAIL_validation.ttl \
+  has_facet_inverse_functional_PASS_validation.ttl \
+  has_facet_inverse_functional_XFAIL_validation.ttl \
   hash_PASS_validation.ttl \
   hash_XFAIL_validation.ttl \
   location_PASS_validation.ttl \

diff --git a/tests/examples/has_facet_inverse_functional_PASS.json b/tests/examples/has_facet_inverse_functional_PASS.json
@@ -0,0 +1,30 @@
+{
+    "@context": {
+        "kb": "http://example.org/kb/",
+        "core": "https://ontology.unifiedcyberontology.org/uco/core/",
+        "owl": "http://www.w3.org/2002/07/owl#"
+    },
+    "@graph": [
+        {
+            "@id": "kb:facet-1",
+            "@type": "core:Facet"
+        },
+        {
+            "@id": "kb:object-1",
+            "@type": "core:UcoObject",
+            "core:hasFacet": {
+                "@id": "kb:facet-1"
+            },
+            "owl:sameAs": {
+                "@id": "kb:object-2"
+            }
+        },
+        {
+            "@id": "kb:object-2",
+            "@type": "core:UcoObject",
+            "core:hasFacet": {
+                "@id": "kb:facet-1"
+            }
+        }
+    ]
+}
diff --git a/tests/examples/has_facet_inverse_functional_PASS_validation.ttl b/tests/examples/has_facet_inverse_functional_PASS_validation.ttl
@@ -0,0 +1,11 @@
+@prefix owl: <http://www.w3.org/2002/07/owl#> .
+@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
+@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
+@prefix sh: <http://www.w3.org/ns/shacl#> .
+@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
+
+[]
+	a sh:ValidationReport ;
+	sh:conforms "true"^^xsd:boolean ;
+	.
+
diff --git a/tests/examples/has_facet_inverse_functional_XFAIL.json b/tests/examples/has_facet_inverse_functional_XFAIL.json
@@ -0,0 +1,26 @@
+{
+    "@context": {
+        "kb": "http://example.org/kb/",
+        "core": "https://ontology.unifiedcyberontology.org/uco/core/"
+    },
+    "@graph": [
+        {
+            "@id": "kb:facet-1",
+            "@type": "core:Facet"
+        },
+        {
+            "@id": "kb:object-1",
+            "@type": "core:UcoObject",
+            "core:hasFacet": {
+                "@id": "kb:facet-1"
+            }
+        },
+        {
+            "@id": "kb:object-2",
+            "@type": "core:UcoObject",
+            "core:hasFacet": {
+                "@id": "kb:facet-1"
+            }
+        }
+    ]
+}
diff --git a/tests/examples/has_facet_inverse_functional_XFAIL_validation.ttl b/tests/examples/has_facet_inverse_functional_XFAIL_validation.ttl
@@ -0,0 +1,68 @@
+@prefix core: <https://ontology.unifiedcyberontology.org/uco/core/> .
+@prefix owl: <http://www.w3.org/2002/07/owl#> .
+@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
+@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
+@prefix sh: <http://www.w3.org/ns/shacl#> .
+@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
+
+[]
+	a sh:ValidationReport ;
+	sh:conforms "false"^^xsd:boolean ;
+	sh:result
+		[
+			a sh:ValidationResult ;
+			sh:focusNode <http://example.org/kb/facet-1> ;
+			sh:resultMessage "hasFacet must not be used to link two objects to one Facet." ;
+			sh:resultPath core:hasFacet ;
+			sh:resultSeverity sh:Violation ;
+			sh:sourceConstraint [
+				a sh:SPARQLConstraint ;
+				sh:message "hasFacet must not be used to link two objects to one Facet."@en ;
+				sh:select """
+			PREFIX core: <https://ontology.unifiedcyberontology.org/uco/core/>
+			PREFIX owl: <http://www.w3.org/2002/07/owl#>
+			SELECT $this ?value
+			WHERE {
+				?value core:hasFacet $this .
+				?nOtherValue core:hasFacet $this .
+				FILTER ( ?value != ?nOtherValue )
+				FILTER NOT EXISTS {
+					?value owl:sameAs|^owl:sameAs ?nOtherValue .
+				}
+			}
+			""" ;
+			] ;
+			sh:sourceConstraintComponent sh:SPARQLConstraintComponent ;
+			sh:sourceShape core:hasFacet-shape ;
+			sh:value <http://example.org/kb/object-1> ;
+		] ,
+		[
+			a sh:ValidationResult ;
+			sh:focusNode <http://example.org/kb/facet-1> ;
+			sh:resultMessage "hasFacet must not be used to link two objects to one Facet." ;
+			sh:resultPath core:hasFacet ;
+			sh:resultSeverity sh:Violation ;
+			sh:sourceConstraint [
+				a sh:SPARQLConstraint ;
+				sh:message "hasFacet must not be used to link two objects to one Facet."@en ;
+				sh:select """
+			PREFIX core: <https://ontology.unifiedcyberontology.org/uco/core/>
+			PREFIX owl: <http://www.w3.org/2002/07/owl#>
+			SELECT $this ?value
+			WHERE {
+				?value core:hasFacet $this .
+				?nOtherValue core:hasFacet $this .
+				FILTER ( ?value != ?nOtherValue )
+				FILTER NOT EXISTS {
+					?value owl:sameAs|^owl:sameAs ?nOtherValue .
+				}
+			}
+			""" ;
+			] ;
+			sh:sourceConstraintComponent sh:SPARQLConstraintComponent ;
+			sh:sourceShape core:hasFacet-shape ;
+			sh:value <http://example.org/kb/object-2> ;
+		]
+		;
+	.
+
diff --git a/tests/examples/test_validation.py b/tests/examples/test_validation.py
@@ -187,6 +187,22 @@ def test_configuration_setting_XFAIL_validation() -> None:
     g = load_validation_graph("configuration_setting_XFAIL_validation.ttl", False)
     assert isinstance(g, rdflib.Graph)
 
+def test_has_facet_inverse_functional_PASS() -> None:
+    confirm_validation_results(
+      "has_facet_inverse_functional_PASS_validation.ttl",
+      True
+    )
+
+def test_has_facet_inverse_functional_XFAIL() -> None:
+    confirm_validation_results(
+      "has_facet_inverse_functional_XFAIL_validation.ttl",
+      False,
+      expected_focus_node_severities={
+        ("http://example.org/kb/facet-1", str(NS_SH.Violation))
+      }
+    )
+
+
 def test_hash_PASS() -> None:
     g = load_validation_graph("hash_PASS_validation.ttl", True)
     assert isinstance(g, rdflib.Graph)