Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should types:Thread have been a subclass of core:UcoObject? #470

Closed
ajnelson-nist opened this issue Aug 24, 2022 · 3 comments
Closed

Should types:Thread have been a subclass of core:UcoObject? #470

ajnelson-nist opened this issue Aug 24, 2022 · 3 comments
Labels
Milestone

Comments

@ajnelson-nist
Copy link
Contributor

Issue 430 is establishing a top-level class core:UcoThing to give a parent class to classes that are not currently explicit subclasses of anything. (Implicitly in OWL, this makes them subclasses of owl:Thing.)

Issue 469 asked about a few "Data structure"-style Dictionary classes that were not subclasses of core:UcoObject, for reasons that I admit I still can't explain.

Issue 393 added a new "Data structure"-style class, types:Thread, that I realize now serves some of the same data model role in UCO that the types:Dictionary class does. However, it was defined in the implementation for 393 to be a subclass of core:UcoObject.

Should types:Thread be a subclass instead of core:UcoThing like the Dictionary class?

This will impact the implementation for Issue 430.

ajnelson-nist added a commit that referenced this issue Aug 24, 2022
This revision was part of the review that led to realizing the new
`types:Thread` is a subclass of `core:UcoObject`, which needs a
committee double-check anchored in Issue 470.

References:
* #430
* #470

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Copy link
Contributor Author

Absent stronger feelings from the committee, I will assume the answer is yes, the correct subclassing for types:Thread is core:UcoThing, not core:UcoObject, and adjust 430's implementation to account for this.

@ajnelson-nist ajnelson-nist added this to the UCO 1.0.0 milestone Aug 24, 2022
@ajnelson-nist
Copy link
Contributor Author

Answer's yes.

ajnelson-nist added a commit that referenced this issue Aug 31, 2022
…archy

References:
* #430
* #470

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Copy link
Contributor Author

Resolved in 57bc4bc, part of resolving Issue 430.

ajnelson-nist added a commit that referenced this issue Aug 31, 2022
Class definitions are as provided by Sean.

This patch reverts much of the impact of
b491c21
on the core namespace.

References:
* #470

Co-authored-by: Sean Barnum <sbarnum@mitre.org>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit that referenced this issue Aug 31, 2022
This patch reverts a word change from
51f3723.

References:
* #470

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant