Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Collections Ontology and test co:List features #390

Merged
merged 9 commits into from
Jun 30, 2022
Merged

Import Collections Ontology and test co:List features #390

merged 9 commits into from
Jun 30, 2022

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented May 26, 2022 •
edited
Loading

This Pull Request resolves all requirements of Issue 389.

Review steps taken:

  • Pull request is against correct branch
  • CI passes in (CASE/UCO) feature branch
  • CI passes in (CASE/UCO) current unstable branch (merge-commit)
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples (N/A)
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io (N/A)
  • Impact on documentation rendering assessed
  • Demonstrate usage in CASE-Examples JSON files (possibly including reconstructed_file.json)

@ajnelson-nist
Move UCO ontology files to /ontology/uco
4c45cbc 
References:
* #387

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Import Collections Ontology and test co:List features
c70c820 
A follow-on patch will generate Make-managed files.

References:
* #389

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Generate Make-managed files
3e27467 
References:
* #389

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist linked an issue May 26, 2022 that may be closed by this pull request
UCO should import the Collections Ontology to handle ordered lists #389
Closed
12 tasks
@ajnelson-nist
Merge branch 'develop' into Feature-Issue-387
6695a0b
@ajnelson-nist
Merge branch 'Feature-Issue-387' into Feature-Issue-389
ebb3329
@ajnelson-nist
Import Collections Ontology (CO) via UCO CO shapes
235fbaa 
References:
* #389

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Normalize
756c8fe 
References:
* #389

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Fix Makefile recursion and syntax
9bbf86d 
References:
* #389

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Track error ontology as submodule
dfc6a96 
This will assist with the review of the transitive closure of the
Collections Ontology.

References:
* #389

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist mentioned this pull request Jun 30, 2022
Closed
12 tasks
@ajnelson-nist ajnelson-nist merged commit 3707cb2 into develop Jun 30, 2022
@ajnelson-nist ajnelson-nist deleted the Feature-Issue-389 branch June 30, 2022 17:15
@ajnelson-nist ajnelson-nist added this to the UCO 1.0.0 milestone Aug 18, 2022
ajnelson-nist added a commit that referenced this pull request Aug 31, 2022
@ajnelson-nist
Add labels to recent ontology files
a701830 
The SHACL import-review ontologies didn't get `rdfs:label`s assigned
when they were created.  This patch adds them to fit style practice with
other UCO ontology files.

No effects were observed on Make-managed files.

References:
* #390
* #406

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
UCO 1.0.0
Development

Successfully merging this pull request may close these issues.

UCO should import the Collections Ontology to handle ordered lists
1 participant
@ajnelson-nist