Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 406 v1: OWL 2 DL review with SHACL-SPARQL #412

Merged
merged 5 commits into from
Aug 12, 2022
Merged

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented Jul 23, 2022

This Pull Request resolves all requirements of Issue #406 .

Review steps taken:

  • Pull request is against correct branch
  • CI passes in (CASE/UCO) feature branch
  • CI passes in (CASE/UCO) current unstable branch (da6226b)
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples (N/A)
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io

This patch undoes an engineering convenience put in place as part of UCO
CP-100.  RDF Lists that were part of semi-open vocabularies were given
IRIs, so they could be referenced for OWL datatype definitions and for
SHACL membership testing.  This was acknowledged as an incompatibility
with OWL 2 DL, which requires that RDF Lists be identified as blank
nodes.  The concepts were intended to remain until an OWL test mechanism
would identify this error.

A test mechanism is now under development as part of UCO Issue 406, and
correctly flags IRI-identified RDF lists.  Hence, this patch undoes the
change.

To ensure the RDF lists are kept in sync. across their duplicate
locations, a Python unit test has been added to confirm list-equality.

References:
* [UCO OC-12] (CP-100) UCO's idea of "Open vocabulary" does not agree
  with its implementation with owl:oneOf
* #406

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
A follow-on patch will refresh Make-managed files.

References:
* #406

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
References:
* #406

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
A draft version of this patch series assisted in reviewing Issue 389.

References:
* #389
* #406

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist changed the base branch from master to develop July 23, 2022 02:06
@ajnelson-nist ajnelson-nist marked this pull request as ready for review July 23, 2022 02:30
@ajnelson-nist ajnelson-nist linked an issue Jul 28, 2022 that may be closed by this pull request
11 tasks
One additional line was supposed to have been copied.  By luck, this
error had still let the remainder of the recipe function, but it's
better to not leave luck in place here.

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Copy link
Contributor Author

ajnelson-nist commented Aug 8, 2022

A patch has been added to fix a syntax error in the top Makefile. The overall patch-series effect remains the same.

@b0bkaT b0bkaT merged commit ed80dd0 into develop Aug 12, 2022
@ajnelson-nist ajnelson-nist added this to the UCO 1.0.0 milestone Aug 18, 2022
@ajnelson-nist ajnelson-nist deleted the Feature-Issue-406 branch August 22, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UCO should perform OWL 2 DL review with SHACL-SPARQL
2 participants