Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 375: Fix CI state with normalization patch #473

Merged
merged 1 commit into from
Aug 27, 2022
Merged

Issue 375: Fix CI state with normalization patch #473

merged 1 commit into from
Aug 27, 2022

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented Aug 27, 2022 •
edited
Loading

The patch in this PR should have been applied before merging PR #414. It's not quite clear at the moment how CI missed it.

This is PR 2 of 3 in resolving Issue 375.

Coordination

  • Pull Request is against correct branch
  • Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed. (N/A - bugfix in PR series)
  • CI passes in (CASE/UCO) feature branch
  • CI passes in UCO current unstable branch (merge-commit)
  • CI passes in CASE current unstable branch tracking UCO's unstable as submodule (merge-commit) (skipped)
  • Impact on SHACL validation reviewed for CASE-Examples (skipped)
  • Impact on SHACL validation remediated for CASE-Examples (skipped)
  • Impact on SHACL validation reviewed for casework.github.io (skipped)
  • Impact on SHACL validation remediated for casework.github.io (skipped)
  • Milestone linked
  • Solutions Approval vote logged on corresponding Issue

@ajnelson-nist
Normalize
6cd5133 
This needed to be applied before merging PR 414.

References:
* #375

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist linked an issue Aug 27, 2022 that may be closed by this pull request
Update Event Facet #375
Closed
12 tasks
@ajnelson-nist ajnelson-nist added this to the UCO 1.0.0 milestone Aug 27, 2022
@ajnelson-nist ajnelson-nist mentioned this pull request Aug 27, 2022
Closed
12 tasks
@ajnelson-nist
Copy link
Contributor Author

Once CI passes in this PR, I will merge this not following two-key protocol because other PRs need it in order for their CI to pass. Before merging this, develop's head fails CI.

@ajnelson-nist ajnelson-nist merged commit 08b5529 into develop Aug 27, 2022
@ajnelson-nist ajnelson-nist deleted the Feature-Issue-375-p2 branch August 27, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
UCO 1.0.0
Development

Successfully merging this pull request may close these issues.

Update Event Facet
1 participant
@ajnelson-nist