Use the correct force_utf8 function based on Python version. #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albu-diku
force-pushed
the
refactor/force_utf8-py-both
branch
2 times, most recently
from
ffbce6b to
a53ada5
Compare
albu-diku
force-pushed
the
refactor/force_utf8-py-both
branch
from
a53ada5 to
e446e41
Compare
This was referenced Nov 2, 2024
Merged
Closed
albu-diku
force-pushed
the
refactor/force_utf8-py-both
branch
from
e446e41 to
7d56ec9
Compare
albu-diku
force-pushed
the
refactor/force_utf8-py-both
branch
from
7d56ec9 to
7842978
Compare
albu-diku
force-pushed
the
refactor/force_utf8-py-both
branch
from
7842978 to
a9d4601
Compare
Import the experimental branch version of force_utf8 wholesale adding a -py(2|3) suffix and expose the correct implementation dependent on PY2. Include forcing InputException messages to a native string as is done in experimental (also taken directly from that branch) which ensures the exception message, which may be unicode, becomes a string everywhere.
albu-diku
force-pushed
the
refactor/force_utf8-py-both
branch
from
a9d4601 to
bed73bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import the experimental branch version of force_utf8 wholesale adding a
-py(2|3) suffix and expose the correct implementation dependent on PY2.
Include forcing InputException messages to a native string as is done in
experimental (also taken directly from that branch) which ensures the
exception message, which may be unicode, becomes a string everywhere.
Depends on: #134