Regression test for valid HTML being generated in the error path. #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albu-diku
force-pushed
the
test/migwsgi
branch
3 times, most recently
from
af91424 to
6a6add4
Compare
albu-diku
force-pushed
the
test/migwsgi
branch
3 times, most recently
from
ff85267 to
e48b12e
Compare
|
I wonder what happened here with all those commits and apparently unrelated files changed? |
albu-diku
force-pushed
the
test/invalid-html-on-error
branch
from
a8582b9 to
b0a3f93
Compare
|
I’m not sure exactly what happened here either. Unfortunately we also landed something a bit different to what this was sat atop so it had also bitrotted - I’ve rewritten the validating assertion along the lines of the title checker and pushed it back up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a test only addition that adds a regression test for the fix that landed as c545adc, the original PR being #178. The test was written at the same time as the original fix but has additional dependencies (#98). With the pre-requisite now in-tree we can now land this and address the follow-up item.