Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Elaboration #736

Merged
merged 10 commits into from
Feb 6, 2025
Merged

Optimize Elaboration #736

merged 10 commits into from
Feb 6, 2025

Conversation

vrindisbacher
Copy link
Collaborator

@vrindisbacher vrindisbacher commented Feb 5, 2025

@ranjitjhala, this one is from the liquid-fixpoint origin but has the same changes as #735

(copying over notes)

A few changes are implemented here:

  • Delaying use of applyExpr in elab until after all the elaboration has taken place.
  • Separate type Visitor and type Folder into two separate structures.
  • Additionally, ditch using the State monad for folding and replace it with the Reader monad - similar to what is implemented for CheckM
  • Ripping out a redundant unifyExpr. This seemed to be re-traversing the expression tree and creating type substitutions by unifying sorts that were already unified in elabEAppSort.

[RJ: All of these together yield massive speedups for some flux benchmarks]

@vrindisbacher vrindisbacher mentioned this pull request Feb 5, 2025
@ranjitjhala ranjitjhala merged commit 54275fd into develop Feb 6, 2025
3 checks passed
@ranjitjhala
Copy link
Member

Thanks @vrindisbacher -- seems to give some nice improvements in the LH benchmarks too!

@vrindisbacher
Copy link
Collaborator Author

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants