Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base Functionality and Styling For FAQ Page #8

Closed
wants to merge 20 commits into from

Conversation

EdwardNew
Copy link
Member

✨ Tracking

Working Towards Resolves Issue #5 (not fully resolved yet)

🌱 Changes

  • Imported and added Accordion Component from Radix-UI
  • Added custom styling for the Accordion Component for both mobile and desktop

📝 Testing

  • Tested on Chrome, Firefox, and only Safari on mobile
  • Tested Accessibiltiy ✅

💻 Did you test on all browsers?

  • Yes
  • No

🔮 Future Features

  • Expand All Button
  • Add Fruit Images

📷Screenshots

image
image

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
up-grade24 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 1:22am

@aaronchan32
Copy link
Member

Looks great! I added some minor style adjustments and added React SVGR to our project so all SVGs are automatically transformed into React components. I would also consider changing the structure of the accordion so that there are multiple rows instead of 2 columns. You can have each row have the same height to fix the issue of overflowing text causing uneven column heights.

@IndiSnacks
Copy link
Contributor

Looks really good! Just a super tiny nit pick the figma we are using a "-" to close the accordion but in the site we are using an "x". I don't think it matters that much bit I'd check with creative.

Uploading Screenshot 2024-06-01 at 12.57.08 PM.jpg…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants