Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Coveralls/Hound CI reporting #34

Closed
mcritchlow opened this issue Feb 3, 2017 · 3 comments
Closed

Add Coveralls/Hound CI reporting #34

mcritchlow opened this issue Feb 3, 2017 · 3 comments
Assignees
Labels

Comments

@mcritchlow
Copy link
Member

Following the work @hweng did on ucsdlib/billing-ill#98

Please add Coveralls and Hound CI to this repo.

For linters, let's start with rubocop. We can also discuss CSS/JS options, but it doesn't have to be in scope for this ticket.

@mcritchlow mcritchlow added this to the Sprint 03 - 2017 milestone Feb 3, 2017
@mcritchlow mcritchlow mentioned this issue Feb 15, 2017
4 tasks
@hweng
Copy link
Contributor

hweng commented Feb 16, 2017

@mcritchlow Should I remove ENV['TRAVIS'] or remove the whole method of coverage_needed? and the "if coverage_needed?" condition https://github.com/ucsdlib/horton/blob/develop/spec/spec_helper.rb#L5 ?

@hweng
Copy link
Contributor

hweng commented Feb 16, 2017

@mcritchlow I prefer to remove "if coverage_needed?" condition. What do you think?

@mcritchlow
Copy link
Member Author

@hweng yeah, I agree. That looks historical, and not particularly relevant now. We're definitely not using Travis, and we're pinned to Rails 5+.

mcritchlow added a commit that referenced this issue Feb 21, 2017
Fixes #34 - Adding hound and rubocop config and coveralls gem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants