We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Following the work @hweng did on ucsdlib/billing-ill#98
Please add Coveralls and Hound CI to this repo.
For linters, let's start with rubocop. We can also discuss CSS/JS options, but it doesn't have to be in scope for this ticket.
The text was updated successfully, but these errors were encountered:
@mcritchlow Should I remove ENV['TRAVIS'] or remove the whole method of coverage_needed? and the "if coverage_needed?" condition https://github.com/ucsdlib/horton/blob/develop/spec/spec_helper.rb#L5 ?
Sorry, something went wrong.
@mcritchlow I prefer to remove "if coverage_needed?" condition. What do you think?
@hweng yeah, I agree. That looks historical, and not particularly relevant now. We're definitely not using Travis, and we're pinned to Rails 5+.
4da6503
Merge pull request #39 from ucsdlib/feature/code_review_tool
6364b86
Fixes #34 - Adding hound and rubocop config and coveralls gem
hweng
No branches or pull requests
Following the work @hweng did on ucsdlib/billing-ill#98
Please add Coveralls and Hound CI to this repo.
For linters, let's start with rubocop. We can also discuss CSS/JS options, but it doesn't have to be in scope for this ticket.
The text was updated successfully, but these errors were encountered: