hyrax 2.0 Beta4 #149
hyrax 2.0 Beta4 #149
Conversation
spec/spec_helper.rb
Outdated
| @@ -121,5 +138,51 @@ | |||
|
|
|||
| config.example_status_persistence_file_path = 'spec/examples.txt' | |||
|
|
|||
| # config.profile_examples = 10 | |||
| =begin | |||
There was a problem hiding this comment.
Style/BlockComments: Do not use block comments.
spec/spec_helper.rb
Outdated
| config.shared_context_metadata_behavior = :apply_to_host_groups | ||
|
|
||
| # The settings below are suggested to provide a good initial experience | ||
| # with RSpec, but feel free to customize to your heart's content. |
There was a problem hiding this comment.
Layout/CommentIndentation: Incorrect indentation detected (column 0 instead of 2).
spec/spec_helper.rb
Outdated
| # a real object. This is generally recommended, and will default to | ||
| # `true` in RSpec 4. | ||
| mocks.verify_partial_doubles = false | ||
| #mocks.syntax = :expect |
There was a problem hiding this comment.
Layout/LeadingCommentSpace: Missing space after #.
spec/rails_helper.rb
Outdated
| unless example.metadata[:type] == :view || example.metadata[:no_clean] | ||
| ActiveFedora::Cleaner.clean! | ||
| end | ||
| end |
There was a problem hiding this comment.
Layout/TrailingWhitespace: Trailing whitespace detected.
spec/rails_helper.rb
Outdated
| # arbitrary gems may also be filtered via: | ||
| # config.filter_gems_from_backtrace("gem name") | ||
|
|
||
| config.before :each do |example| |
There was a problem hiding this comment.
RSpec/HookArgument: Omit the default :each argument for RSpec hooks.
spec/rails_helper.rb
Outdated
| config.filter_rails_from_backtrace! | ||
| # arbitrary gems may also be filtered via: | ||
| # config.filter_gems_from_backtrace("gem name") | ||
|
|
There was a problem hiding this comment.
Layout/TrailingWhitespace: Trailing whitespace detected.
app/models/solr_document.rb
Outdated
| use_extension(Hydra::ContentNegotiation) | ||
|
|
||
| use_extension( Hydra::ContentNegotiation ) | ||
There was a problem hiding this comment.
Layout/TrailingWhitespace: Trailing whitespace detected.
app/models/solr_document.rb
Outdated
| @@ -27,8 +27,8 @@ class SolrDocument | |||
|
|
|||
| # Do content negotiation for AF models. | |||
|
|
|||
| use_extension(Hydra::ContentNegotiation) | |||
|
|
|||
| use_extension( Hydra::ContentNegotiation ) | |||
There was a problem hiding this comment.
Layout/SpaceInsideParens: Space inside parentheses detected.
VivianChu
force-pushed
the
feature/evaluate_hyrax4
branch
from
2fd55c5 to
9c64435
Compare
Update ruby version Fix rubocop defenses Fix rubocop defenses
VivianChu
force-pushed
the
feature/evaluate_hyrax4
branch
from
9c64435 to
ae09f5c
Compare
Fixes #145 ; refs #145
Evaluate Hyrax 2.0 beta4 (clean) vs Horton as-is.
@ucsdlib/developers - please review