Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] pgx v5 #25

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

[WIP] pgx v5 #25

wants to merge 13 commits into from

Conversation

cjfinnell
Copy link

No description provided.

require-error: for error assertions use require (testifylint)
fmt.Sprintf can be replaced with faster strconv.Itoa (perfsprint)
Output from linter:
(Config).runTestQueriesOnTarget - result 1 (error) is always nil (unparam)
Linter error:
interface method apply must have all named params (inamedparam)
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #25 (ec233dd) into main (685e687) will increase coverage by 1.21%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   77.38%   78.59%   +1.21%     
==========================================
  Files           6        6              
  Lines         566      570       +4     
==========================================
+ Hits          438      448      +10     
+ Misses        106      101       -5     
+ Partials       22       21       -1     
Files Coverage Δ
config.go 75.67% <ø> (ø)
log.go 64.70% <91.66%> (+64.70%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant