forked from cjfinnell/pgverify
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] pgx v5 #25
Draft
cjfinnell
wants to merge
13
commits into
main
Choose a base branch
from
cjfinnell/pgx-v5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP] pgx v5 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
require-error: for error assertions use require (testifylint)
fmt.Sprintf can be replaced with faster strconv.Itoa (perfsprint)
Output from linter: (Config).runTestQueriesOnTarget - result 1 (error) is always nil (unparam)
Linter error: interface method apply must have all named params (inamedparam)
cjfinnell
force-pushed
the
cjfinnell/pgx-v5
branch
from
October 24, 2023 17:34
6345edc
to
5d37169
Compare
cjfinnell
force-pushed
the
cjfinnell/pgx-v5
branch
from
October 24, 2023 17:34
5d37169
to
ec233dd
Compare
Codecov Report
@@ Coverage Diff @@
## main #25 +/- ##
==========================================
+ Coverage 77.38% 78.59% +1.21%
==========================================
Files 6 6
Lines 566 570 +4
==========================================
+ Hits 438 448 +10
+ Misses 106 101 -5
+ Partials 22 21 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.