Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: subscript and superscript were mixed up #3236

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

LeonMueller-OneAndOnly
Copy link

@LeonMueller-OneAndOnly LeonMueller-OneAndOnly commented May 31, 2024

Dear maintainers,

I noticed following bug in the playground demo and provide a small and straight forward fix to it.

The labels were simply mixed up and the clearing behaviour could not handle changing a subscript to a supscript or vice versa.

With best regards,
Leon Müller

Copy link

vercel bot commented May 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ❌ Failed (Inspect) May 31, 2024 6:02pm

Copy link

changeset-bot bot commented May 31, 2024

⚠️ No Changeset found

Latest commit: 06bb33e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zbeyens
Copy link
Member

zbeyens commented May 31, 2024

Thanks! Here is the error:

2024-05-31 at 20 32 56

@LeonMueller-OneAndOnly
Copy link
Author

Weird! If have just today forked the playground demo where i use a string array (just like committed here) - in order to clear both marks for subscript and subscript when toggling one.

There typescript allowed a string array and it fixed the issue that you cant switch from subscript to supscript or vice versa.

@zbeyens zbeyens marked this pull request as draft June 6, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants