fix: focus the editor before opening the floating link toolbar #4073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
🦋 Changeset detectedLatest commit: ae51aaa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
yarn typecheckyarn lint:fixyarn testyarn brlyarn changesetBefore, if the user clicked the link button in the toolbar when the editor was not focused, the floating toolbar popup would show up near or off the edge of the editor.
Now, clicking the link button will first auto-focus on the editor before opening up the floating link popup. That way the floating popup always appears in the correct position.
While I am not sure, this fix sounds like it may fix issue #3812. I tried to reproduce the bug described in this issue, however the symptoms I was experiencing were slightly different. I noticed the floating popover was misplaced after the first click of the link button, whereas they reported the issue after the second click. This may fix both issues though.