fix: return value of useEditorPlugin changes when rerender

[regmsif]

Before, if there are two tables in one document, selecting multiple table cells will cause page crash, like #4077. Now it will work normally.

The problem is that useEditorPlugin doesn't return a stable value. In useSelectedCells, the setOption returned by useEditorPlugin will change in every re-render. While the useSelectedCells called by the first table sets selectedCells to a non-null value, the useSelectedCells called by the second table will set selectedCells back to null, and it repeats infinitely.

  // for the second table, `selected = false`, so it will set `selectedCells` to null when `setOption` changes
  React.useEffect(() => {
    if (!selected || readOnly) {
      setOption('selectedCells', null);
      setOption('selectedTables', null);
    }
  }, [selected, editor, readOnly, setOption]);

Removing setOption from dependency array also fixes this problem, but I'm not sure whether there are similar problems in other functions, so I make the return value of useEditorPlugin memorized.

Checklist

• yarn typecheck
• yarn lint:fix
• yarn test
• yarn brl
• yarn changeset
• ui changelog

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
plate	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 18, 2025 1:10pm

[changeset-bot]

🦋 Changeset detected

Latest commit: 6b8e2f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@udecode/plate-core	Patch
@udecode/plate-utils	Patch
@udecode/plate	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[zbeyens]

Good catch, thanks for the PR!