New GC for C host #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo-ard
requested changes
Sep 26, 2024
There was a problem hiding this comment.
Really good ! I did put some comments, but it's mostly nit picking and renaming.
The only things missing is tests ! Once you change the names for the features, you can add it to the features list (TEST_FEATURE) of the C host. Read here how to do that : https://github.com/udem-dlteam/ribbit/tree/main/src/tests#makefile-example. I would add both the mark-and-sweep algorithm with and without the DSW optimization. If the CI is too long, we can remove the mark-and-sweep algorithm without DSW.
leo-ard
reviewed
Sep 26, 2024
leo-ard
reviewed
Sep 26, 2024
leo-ard
reviewed
Oct 10, 2024
|
@l4haie The rest looks good ! If you fix the warning of the RVM in the CI and the time it takes (see comment above) it should be ready to be merged ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of a few garbage collection algorithms to be used as a benchmark for the new GC.