Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move apply primitives to their respective hosts #78

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

l4haie
Copy link
Collaborator

@l4haie l4haie commented Oct 31, 2024

This PR simply moves the apply primitives from lib/r4rs/control.scm to their respective hosts (i.e. to host/<host>/lib/prim-apply.scm) to remain consistent with other primitives defined using the define-primitive construct (IO primitives, ...).

@l4haie l4haie requested a review from leo-ard October 31, 2024 20:14
@l4haie l4haie changed the title Move apply primitive to respective host Move apply primitives to their respective hosts Oct 31, 2024
@leo-ard
Copy link
Collaborator

leo-ard commented Oct 31, 2024

@l4haie You must add one empty file to host/asm/lib/prim-apply.scm to make sure the importation of prim-apply doesn't crash for the asm host. The apply primitive in this case is inside the RVM. See host/asm/lib/prim-io.scm to understand

@l4haie
Copy link
Collaborator Author

l4haie commented Oct 31, 2024

@l4haie You must add one empty file to host/asm/lib/prim-apply.scm to make sure the importation of prim-apply doesn't crash for the asm host. The apply primitive in this case is inside the RVM. See host/asm/lib/prim-io.scm to understand

Done.

Copy link
Collaborator

@leo-ard leo-ard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leo-ard leo-ard merged commit 39f2b95 into main Oct 31, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants