Updates AWS managed policies

[udondan]

Updates AWS managed policies

Summary by CodeRabbit

• New Features

  • Introduced SSMQuickSetupRolePolicy for enhanced AWS Systems Manager (SSM), AWS Organizations, and AWS CloudFormation permissions.

• Documentation

  • Added documentation for SSMQuickSetupRolePolicy permissions.

• Enhancements

  • Added methods and properties to manage and enforce new AWS permissions efficiently.

[coderabbitai]

Walkthrough

This update introduces a new AWS-managed policy file (SSMQuickSetupRolePolicy.json) and modifications to the cdk-iam-floyd.ts and iam-floyd.ts files in the AWS managed policies library. These changes grant permissions for various AWS Systems Manager (SSM), AWS Organizations, and AWS CloudFormation actions, facilitating tasks such as listing resources, describing documents, and managing stack sets. Additionally, the AwsManagedPolicy class has been updated to integrate these new permissions.

Changes

Files/Paths	Change Summary
docs/source/_static/managed-policies/SSMQuickSetupRolePolicy.json	Added a new file introducing permissions for SSM, Organizations, and CloudFormation actions.
lib/generated/aws-managed-policies/cdk-iam-floyd.ts	Added SSMQuickSetupRolePolicy method to the AwsManagedPolicy class for Quick Setup configuration health and resource drift detection permissions.
lib/generated/aws-managed-policies/iam-floyd.ts	Added SSMQuickSetupRolePolicy static property to the AwsManagedPolicy class for permissions related to SSM Quick Setup.

Sequence Diagram(s)

Here's a high-level sequence diagram illustrating the interaction flow enabled by the new SSMQuickSetupRolePolicy:

sequenceDiagram
    participant User
    participant IAMPolicyClass as AwsManagedPolicy
    participant SSM as AWS SSM
    participant Org as AWS Organizations
    participant CF as AWS CloudFormation
    
    User->>IAMPolicyClass: Request for SSMQuickSetupRolePolicy
    IAMPolicyClass->>SSM: ListResourceDataSync, GetOpsSummary
    IAMPolicyClass->>SSM: ListAssociations, DescribeAssociationExecutions
    IAMPolicyClass->>SSM: DescribeDocument, GetDocument
    IAMPolicyClass->>Org: ListRoots, ListAWSServiceAccessForOrganization
    IAMPolicyClass->>Org: ListDelegatedAdministrators, ListAccountsForParent
    IAMPolicyClass->>Org: ListOrganizationalUnitsForParent
    IAMPolicyClass->>CF: DescribeStackSet, DescribeStackSetOperation
    IAMPolicyClass->>CF: ListStackInstances, ListStackSetOperations
    IAMPolicyClass->>CF: ListStackSetOperationResults, DeleteStackInstances, DeleteStackSet
    IAMPolicyClass->>User: Return Policy Details

Loading

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0f08145 and fc0c081.

Files selected for processing (4)

• docs/source/_static/managed-policies/SSMQuickSetupRolePolicy.json (1 hunks)
• docs/source/_static/managed-policies/index.json (1 hunks)
• lib/generated/aws-managed-policies/cdk-iam-floyd.ts (1 hunks)
• lib/generated/aws-managed-policies/iam-floyd.ts (1 hunks)

Files not summarized due to errors (1)

• docs/source/_static/managed-policies/index.json: Error: Message exceeds token limit

Additional context used

Biome

lib/generated/aws-managed-policies/iam-floyd.ts

[error] 2-2415: Avoid classes that contain only static members. (lint/complexity/noStaticOnlyClass)

Prefer using simple functions instead of classes with only static members.

Gitleaks

lib/generated/aws-managed-policies/iam-floyd.ts

1208-1208: Detected a Generic API Key, potentially exposing access to various services and sensitive operations. (generic-api-key)

Additional comments not posted (10)

docs/source/_static/managed-policies/SSMQuickSetupRolePolicy.json (7)

5-10: Permission block review: SSMResourceDataSyncPermissions

This block properly grants the ssm:ListResourceDataSync action. The Resource set to "*" implies it applies to all resources, which is typical for list operations.

---

13-18: Permission block review: SSMResourceDataSyncGetOpsSummaryPermissions

The permission restricts the ssm:GetOpsSummary action to resources prefixed with AWS-QuickSetup-*. This is a good practice as it limits the scope to relevant resources only.

---

21-27: Permission block review: SSMAssociationsReadOnlyPermissions

This block allows listing and describing SSM associations. The unrestricted resource scope ("*") is typical for read-only actions that do not modify resources.

---

30-39: Permission block review: QuickSetupSSMDocumentsReadOnlyPermissions

The actions ssm:DescribeDocument and ssm:GetDocument are correctly scoped to only Quick Setup related documents. The use of wildcards in the ARN is appropriate here to cover all relevant documents.

---

42-51: Permission block review: OrganizationReadOnlyPermissions

This block covers a variety of read-only operations on AWS Organizations. Setting the resource to "*" is acceptable for these listing and descriptive actions.

---

54-66: Permission block review: QuickSetupStackSetReadOnlyPermissions

This block correctly scopes CloudFormation stack set operations to Quick Setup related resources. The inclusion of both stackset and stack resources ensures comprehensive coverage.

---

69-85: Permission block review: QuickSetupStackSetDeletePermissions

This block allows deletion of CloudFormation stack instances and sets, with a condition that ensures operations are restricted to the principal's account. This is a crucial security measure for destructive operations.

docs/source/_static/managed-policies/index.json (1)

1-1: Addition of SSMQuickSetupRolePolicy

The SSMQuickSetupRolePolicy has been correctly added to the list of managed policies. This ensures it's discoverable and usable within the system.

lib/generated/aws-managed-policies/iam-floyd.ts (1)

2383-2384: New static property addition for SSM Quick Setup Role Policy

The addition of public static SSMQuickSetupRolePolicy = 'aws-service-role/SSMQuickSetupRolePolicy'; is consistent with the PR's objective to update AWS managed policies. This static property is crucial for managing permissions related to the Quick Setup configuration health and resource drift detection in AWS SSM.

• Correctness: The property name and value seem to be correctly defined and follow the naming conventions used for other properties in this file.
• Maintainability: Adding a detailed comment explaining the purpose of this property enhances maintainability and understandability for future code maintainers.
• Security: This change does not introduce any direct security implications as it is a configuration definition.

lib/generated/aws-managed-policies/cdk-iam-floyd.ts (1)

5962-5965: New method SSMQuickSetupRolePolicy added for managing SSM Quick Setup permissions.

The method is well-documented and follows the pattern established by other methods in the class. It correctly uses the static property SSMQuickSetupRolePolicy from the AwsManagedPolicyStatic class to fetch the managed policy name. This ensures that the policy management is consistent with the rest of the system's architecture.

However, ensure that the static property SSMQuickSetupRolePolicy is correctly defined and accessible in the AwsManagedPolicyStatic class as expected.

Verification successful

---

Static property SSMQuickSetupRolePolicy is correctly defined in the AwsManagedPolicyStatic class.

The property SSMQuickSetupRolePolicy is found in the lib/generated/aws-managed-policies/iam-floyd.ts file, confirming its existence and correct definition. The new method SSMQuickSetupRolePolicy in cdk-iam-floyd.ts is consistent with the existing architecture.

• lib/generated/aws-managed-policies/iam-floyd.ts:

  public static SSMQuickSetupRolePolicy = 'aws-service-role/SSMQuickSetupRolePolicy';

Scripts executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify the existence of SSMQuickSetupRolePolicy in AwsManagedPolicyStatic class.

# Test: Search for the property definition in the class. Expect: A single occurrence of the property.
ast-grep --lang typescript --pattern $'class AwsManagedPolicyStatic {
  $$$
  SSMQuickSetupRolePolicy = $_;
  $$$
}'

Length of output: 117

---

---

Script:

#!/bin/bash
# Description: Verify the existence of SSMQuickSetupRolePolicy in the codebase.

# Test: Search for the property definition in the class. Expect: A single occurrence of the property.
rg 'SSMQuickSetupRolePolicy' --type ts

Length of output: 452

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.