Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates AWS managed policies #809

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Updates AWS managed policies #809

merged 1 commit into from
Jul 2, 2024

Conversation

udondan
Copy link
Owner

@udondan udondan commented Jul 2, 2024 •
edited by coderabbitai bot
Loading

Updates AWS managed policies

Summary by CodeRabbit

  • New Features

    • Enhanced permissions for Amazon SageMaker Service Catalog, including support for API Gateway, CloudFormation, CodeBuild, CodeCommit, CodePipeline, CIAM, ECR, EventBridge, Firehose, Glue, Lambda, S3, SageMaker, Step Functions, CodeStar, and CodeConnections actions.

  • Bug Fixes

    • Removed unnecessary sns:Publish action from Amazon RDS Service Role Policy for improved security.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jul 2, 2024 •
edited
Loading

Walkthrough

This update includes modifications to two Amazon Web Services (AWS) managed policies. The sns:Publish action has been removed from the AmazonRDSServiceRolePolicy.json policy. Additionally, the AmazonSageMakerAdmin-ServiceCatalogProductsServiceRolePolicy.json policy has been enhanced by adding permissions for various AWS services and actions relevant to Amazon SageMaker Service Catalog Operations.

Changes

File Change Summary
docs/source/_static/managed-policies/AmazonRDSServiceRolePolicy.json Removed the sns:Publish action from the AmazonRDSServiceRolePolicy policy.
docs/source/_static/managed-policies/AmazonSageMakerAdmin-ServiceCatalogProductsServiceRolePolicy.json Added permissions for various actions related to Amazon SageMaker Service Catalog, such as API Gateway, CloudFormation, Lambda, and more.
Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a54646f and 13440d6.

Files selected for processing (2)
  • docs/source/_static/managed-policies/AmazonRDSServiceRolePolicy.json (1 hunks)
  • docs/source/_static/managed-policies/AmazonSageMakerAdmin-ServiceCatalogProductsServiceRolePolicy.json (32 hunks)
Files skipped from review due to trivial changes (1)
  • docs/source/_static/managed-policies/AmazonRDSServiceRolePolicy.json
Additional comments not posted (27)
docs/source/_static/managed-policies/AmazonSageMakerAdmin-ServiceCatalogProductsServiceRolePolicy.json (27)

Line range hint 5-14: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows various API Gateway actions with a condition on a specific tag.

Line range hint 22-35: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows the apigateway:POST action with a condition on specific tag keys.

Line range hint 37-45: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows the apigateway:PATCH action on a specific resource.

Line range hint 47-62: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows various CloudFormation actions with a condition on the role ARN.

64-76: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows tagging and untagging of CloudFormation resources with a condition on a specific resource tag.

Line range hint 77-85: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows read-only actions on CloudFormation stacks.

Line range hint 87-94: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows actions related to CloudFormation templates.

Line range hint 96-105: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows various CodeBuild actions on specific resources.

Line range hint 108-119: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows various CodeCommit actions on specific repositories.

122-128: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows listing of CodeCommit repositories.

Line range hint 130-144: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows various CodePipeline actions on specific pipelines.

Line range hint 146-160: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows various Cognito Identity actions with a condition on specific tag keys.

Line range hint 162-183: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows various Cognito Identity actions with a condition on a specific resource tag.

Line range hint 185-194: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows various ECR actions on specific repositories.

Line range hint 197-211: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows various EventBridge actions on specific rules.

Line range hint 213-224: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows various Firehose actions on specific delivery streams.

Line range hint 226-238: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows various Glue actions on specific resources.

Line range hint 240-254: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows various Glue classifier actions on all resources.

Line range hint 256-264: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows the creation of Glue workflows on specific resources.

Line range hint 266-274: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows the creation of Glue jobs on specific resources.

Line range hint 276-285: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows the creation and retrieval of Glue crawlers on specific resources.

Line range hint 287-296: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows the creation and retrieval of Glue triggers on specific resources.

Line range hint 298-306: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows the iam:PassRole action on specific roles.

Line range hint 308-322: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows various Lambda actions on specific functions.

Line range hint 324-337: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows tagging of Lambda functions with a condition on specific tag keys.

Line range hint 339-354: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows various CloudWatch Logs actions on specific log groups and log streams.

Line range hint 356-365: LGTM! Policy statement is well-formed and follows best practices.

The policy statement allows read-only actions on S3 objects with a condition on a specific object tag.

Tip

Early access features: enabled

We are currently testing the following features in early access:

  • OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues.
  • OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@udondan udondan merged commit 7d44084 into main Jul 2, 2024
8 checks passed
@udondan udondan deleted the update-aws-managed-policies branch July 2, 2024 01:36
@coderabbitai coderabbitai bot mentioned this pull request Sep 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@udondan