-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression v9->v10: tasks storing wakers aren't dropped #30
Comments
I'm sure It's totally wrong to delay dropping a task due to the existence of some related wakers because they can live infinitely long in general cases. |
loyd
added a commit
to loyd/unicycle
that referenced
this issue
Aug 3, 2024
loyd
added a commit
to loyd/unicycle
that referenced
this issue
Aug 3, 2024
loyd
added a commit
to loyd/unicycle
that referenced
this issue
Aug 3, 2024
loyd
added a commit
to loyd/unicycle
that referenced
this issue
Aug 3, 2024
loyd
added a commit
to loyd/unicycle
that referenced
this issue
Aug 3, 2024
udoprog
pushed a commit
that referenced
this issue
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#28 introduced an unexpected regression.
To support removing from the slab (until #26), I store a waker inside tasks added to
StreamsUnordered
. The current implementation never decrementsHeader::reference_count
to zero in such cases, leading to a leak and preventing the task from dropping.A test to reproduce locally:
The text was updated successfully, but these errors were encountered: