Fix:E-claim toggle list button #507 #528
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iEdmar
commented
Jan 17, 2025
| @@ -70,13 +70,15 @@ export class EClaimHomeComponent implements OnInit { | |||
| this.loadedData = false; | |||
| this.visitService.getAllVisits(null, null, true).subscribe( | |||
| (visits) => { | |||
| console.log('Fetched Active Visits:', visits); | |||
There was a problem hiding this comment.
Added a line for console.log to check for fetched active visits status
Maganga-Rafia
approved these changes
Jan 17, 2025
**_Reason for the bug_**
File: /patient-list.component.html
The condition for rendering the tabular list includes an additional filter for paymentTypeSelected: `*ngIf="
isTabularList &&
params?.visits &&
params?.visits.length > 0 &&
((paymentTypeSelected && visit?.visit?.paymentType === paymentTypeSelected) ||
!paymentTypeSelected)
"`
Compare this with the condition for rendering the account_box view: `***ngIf="params?.visits && params?.visits.length > 0"**` Because of the added filter complexity result in the tabular list not being displayed due to mismatches in data or payme ntTypeSelected.
**_So, by removing the additional complexity the toggle list works as expected._**
500 Internal Server Error: The API endpoint http://localhost:4200/openmrs/ws/rest/v1/icare/visit?&startIndex=undefined&limit=undefined is returning a 500 error. The error likely stems from the startIndex and limit query parameters being undefined. I resolve by adding predefined values for startIndex and limit to the getAllVisit function as initialization and error resolved.
…ar/iCareConnect into feature/toggle-patient-list
|
Hello, everyone!
For those who have completed their assignment tasks, please follow these
steps to submit your work:
1.
*Create a Feature Branch*
- Name the branch based on the task you're working on, e.g.,
feature/labnotification.
2.
*Push Your Work*
- Push all your changes to the newly created feature branch.
3.
*Create a Pull Request*
- Create a pull request directed to the account named iamgaspardev for
review of your work.
*Note:*
- Do not push changes to your personal GitHub account.
- Push from the repository you pulled from and ensure the changes are in
the feature branch you created.
Thanks and Regards,
Ramadhani Mbiaji
Health Information System Analyst
UDSM DHIS2 LAB <https://dhis2.udsm.ac.tz/#/home>
College of Information and Communication Technology (CoICT)
Department of Computer Science and Engineering
University of Dar-es-salaam
Mobile Number: *+255 693 012 480*
Useful Links: GitHub <https://github.com/Ramadhani202208>, LinkedIn
<https://www.linkedin.com/in/ramadhani-mbiaji-2881b0ab/>
Website: https://dhis2.udsm.ac.tz
…On Fri, 17 Jan 2025 at 10:24, Edmar Isdor ***@***.***> wrote:
*Console Logs for Debugging*
Added console.log statements to test the behavior of the tabular view
under specific conditions. These logs were used to validate functionality
and identify any issues during development.
Screenshot.from.2025-01-17.10-20-25.png (view on web)
<https://github.com/user-attachments/assets/3a94ef26-8ba4-4fe4-b632-66a217d13930>
------------------------------
You can view, comment on, or merge this pull request online at:
#528
Commit Summary
- 07a9f6e
<07a9f6e>
Fix:E-claim toggle list button #507 in icareconnect
File Changes
(4 files <https://github.com/udsm-dhis2-lab/iCareConnect/pull/528/files>)
- *M*
ui/src/app/modules/e-claim/pages/e-claim-home/e-claim-home.component.ts
<https://github.com/udsm-dhis2-lab/iCareConnect/pull/528/files#diff-c16a4aa8dac980fb2edec194a3c50d6fe6c06b99d77ba40d6e3edfa524b9749d>
(2)
- *M*
ui/src/app/shared/components/patient-list/patient-list.component.html
<https://github.com/udsm-dhis2-lab/iCareConnect/pull/528/files#diff-395f94c3d2d6df32f58cc32a9ce495a6766583e7fafb5be3af765a7fd0220c16>
(9)
- *M*
ui/src/app/shared/components/patient-list/patient-list.component.ts
<https://github.com/udsm-dhis2-lab/iCareConnect/pull/528/files#diff-bb6711d2de0bf45de4b1aa26ff13e335c33569dfa1f0f59da371841ff392d9b8>
(9)
- *M* ui/src/app/shared/resources/visits/services/visits.service.ts
<https://github.com/udsm-dhis2-lab/iCareConnect/pull/528/files#diff-76b75ba75c587f6fdcb119c4623537d726cd487927a88f1ea84625ccb21f624a>
(5)
Patch Links:
- https://github.com/udsm-dhis2-lab/iCareConnect/pull/528.patch
- https://github.com/udsm-dhis2-lab/iCareConnect/pull/528.diff
—
Reply to this email directly, view it on GitHub
<#528>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2TLCLGATWDDYZFAUZMR3G32LCVZXAVCNFSM6AAAAABVLJIGCOVHI2DSMVQWIX3LMV43ASLTON2WKOZSG44TINZWGQ2DENA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Console Logs for Debugging
Added
console.logstatements to test the behavior of the tabular view under specific conditions. These logs were used to validate functionality and identify any issues during development.Group 17: Members participated
01: Muddy Ramadhan Fakih(2022-04-01851)
02: Rafia Ramadhan Maganga(2022-04-05593)
03: Edmar Isdor Ngimba(2022-04-10262 )
04: Aisha Mussa Mzava(2022-04-09813)
05: ABDILLAH AHMED ISSA(2022-04-02740)