Change Location button in the system

[2cyprian]

Fix bug: Change location button in the system #77
What we did :
• traced the bug ( by inspecting the directed page in google chrome and traced the element by searching in VSCode which was our IDE.
• found in element[View here] required for routing was commented and not linked
• uncomment the logic and added some features
• the areas with changes are clearly commented
Challenges Faced

1. Environment Setup Issues:
   • Instead of using set for Windows in the package.json file, we switched to cross-env to ensure compatibility across different operating systems.
2. Proxy URL Authentication Problems:
   • The prior proxy URL caused issues with logging in, requiring modifications and thorough debugging to resolve.
3. Difficulty Identifying the Bug’s Source:
   • It was particularly hard to locate the appropriate file responsible for the issue due to the complexity and structure of the codebase.
4. Remaining Functional Issues:
   • After resolving the main error, Dashboard, General, and Human Resource Skills screens still fail to load, while other screens work as expected.

• For the Billing screen, users must refresh the page to load the content, which disrupts the user experience.
5. Unfamiliar With programing Language
Solution [the Fix]

1. Improved Filtering Logic:
   • Fix incomplete filtering logic to handle edge cases where location data or attributes are missing. [view here]
2. Non-Blocking Event Listener:

• Optimize debounce logic to prevent blocking user interactions while the application processes data. [view here]
3. Added error handling logic in [view here] to identify and log any issues in the code.[view here]

####TESTING THE FEATURE
Steps to reproduce the behavior:

1. Look for location icon in App navbar
2. Click on 'location icon'
3. Click on ‘Exemption’
4. link in the address bar should be http://localhost:4200/#/billing/exemption Then click to see the content in the link
   Expected behavior
   The user expects that when the navigation bar is clicked, a list will be displayed. Furthermore, when an item on the list is clicked, it should open without waiting long time for loading screen.

CONTRIBUTORS: GROUP 21
01.CRESENSIA NKEMBO 2021-04-09834 NKEMBOCRESSY

02.EMMANUEL CYPRIAN 2022-04-01391 2cyprian

3. SARA MPOLO 2022-04-08323 wailesy

04.STEVEN CHUMBI 2022-04-01333 Stevedev13

05.ERICK GEORGE PAULO 2022-04-13700 gregoryerick254

Bug 77 in software eng.pdf

[Moricembiaji]

Hello, everyone! For those who have completed their assignment tasks, please follow these steps to submit your work: 1. *Create a Feature Branch* - Name the branch based on the task you're working on, e.g., feature/labnotification. 2. *Push Your Work* - Push all your changes to the newly created feature branch. 3. *Create a Pull Request* - Create a pull request directed to the account named iamgaspardev for review of your work. *Note:* - Do not push changes to your personal GitHub account. - Push from the repository you pulled from and ensure the changes are in the feature branch you created. Thanks and Regards, Ramadhani Mbiaji Health Information System Analyst UDSM DHIS2 LAB <https://dhis2.udsm.ac.tz/#/home> College of Information and Communication Technology (CoICT) Department of Computer Science and Engineering University of Dar-es-salaam Mobile Number: *+255 693 012 480* Useful Links: GitHub <https://github.com/Ramadhani202208>, LinkedIn <https://www.linkedin.com/in/ramadhani-mbiaji-2881b0ab/> Website: https://dhis2.udsm.ac.tz

…

On Fri, 17 Jan 2025 at 16:00, Emmanuel Cyprian ***@***.***> wrote: Fix bug: Change location button in the system #77 <#77> What we did : • traced the bug ( by inspecting the directed page in google chrome and traced the element by searching in VSCode which was our IDE. • found in element[View here <https://github.com/udsm-dhis2-lab/iCareConnect/blob/main/ui/src/app/core/containers/modules/modules.component.ts>] required for routing was commented and not linked • uncomment the logic and added some features • the areas with changes are clearly commented Challenges Faced 1. Environment Setup Issues: • Instead of using set for Windows in the package.json file, we switched to cross-env to ensure compatibility across different operating systems. 2. Proxy URL Authentication Problems: • The prior proxy URL caused issues with logging in, requiring modifications and thorough debugging to resolve. 3. Difficulty Identifying the Bug’s Source: • It was particularly hard to locate the appropriate file responsible for the issue due to the complexity and structure of the codebase. 4. Remaining Functional Issues: • After resolving the main error, Dashboard, General, and Human Resource Skills screens still fail to load, while other screens work as expected. image.png (view on web) <https://github.com/user-attachments/assets/dd02571d-e80b-423a-8b02-20879f436a3c> • For the Billing screen, users must refresh the page to load the content, which disrupts the user experience. 5. Unfamiliar With programing Language Solution [the Fix] 1. Improved Filtering Logic: • Fix incomplete filtering logic to handle edge cases where location data or attributes are missing. [view here] 2. Non-Blocking Event Listener: • Optimize debounce logic to prevent blocking user interactions while the application processes data. [view here] 3. Added error handling logic in [view here] to identify and log any issues in the code.[view here <https://github.com/udsm-dhis2-lab/iCareConnect/compare/main...2cyprian:iCareConnect:2cyprian?expand=1> ] ####TESTING THE FEATURE Steps to reproduce the behavior: 1. Look for location icon in App navbar 2. Click on 'location icon' 3. Click on ‘Exemption’ 4. link in the address bar should be http://localhost:4200/#/billing/exemption Then click to see the content in the link Expected behavior The user expects that when the navigation bar is clicked, a list will be displayed. Furthermore, when an item on the list is clicked, it should open without waiting long time for loading screen. image.png (view on web) <https://github.com/user-attachments/assets/d53f72cb-fdea-44b3-acbb-14270d3388ec> CONTRIBUTORS: GROUP 21 01.CRESENSIA NKEMBO 2021-04-09834 NKEMBOCRESSY 02.EMMANUEL CYPRIAN 2022-04-01391 2cyprian 3. SARA MPOLO 2022-04-08323 wailesy 04.STEVEN CHUMBI 2022-04-01333 Stevedev13 05.ERICK GEORGE PAULO 2022-04-13700 gregoryerick254 Bug 77 in software eng.pdf <https://github.com/user-attachments/files/18454692/Bug.77.in.software.eng.pdf> ------------------------------ You can view, comment on, or merge this pull request online at: #540 Commit Summary - 7bb59ec <7bb59ec> added empty error handling on gepg - 4c21348 <4c21348> Merge branch 'develop' of https://github.com/udsm-dhis2-lab/iCareConnect into hotfix/gepgerrorhandling - 4aeb25d <4aeb25d> added empty error handling on gepg and merges - 6d9213c <6d9213c> Added support to ensure field type input is taken on dose and duration - 2bc1042 <2bc1042> Merge pull request #490 from udsm-dhis2-lab/hotfix/gepgerrorhandling - c57f656 <c57f656> Added support to ensure field type input is taken on dose and duration - d171de1 <d171de1> Merge pull request #491 from udsm-dhis2-lab/hotfix/gepgerrorhandling - 769dede <769dede> Added support to ensure GePG Request handless error from live - cad4f2e <cad4f2e> Added support to ensure GePG Request handless error from live - 2f6712e <2f6712e> Added support to ensure GePG Request handless error from live - 150b406 <150b406> Added support to ensure GePG Request handless error from live - e3c54a8 <e3c54a8> Added support to avoid duplication on chiplist on issuing and requested - 2d4b805 <2d4b805> Merge pull request #492 from udsm-dhis2-lab/hotfix/gepgerrorhandling - b100013 <b100013> Added support to allow user to add multiple visit note - 466be63 <466be63> Merge pull request #493 from udsm-dhis2-lab/hotfix/gepgerrorhandling - 30c0450 <30c0450> Added support to check time from global properties - e3566ec <e3566ec> Added support to check time from global properties - c41c53b <c41c53b> Merge pull request #494 from udsm-dhis2-lab/feature/clinic-notes - 62292ce <62292ce> uncomment ngonInit() logic and this store dipatch - 1393fb7 <1393fb7> paste created handle error logic - f7685f6 <f7685f6> Added loading state management - d48d116 <d48d116> changed moduless.component to make sure loaction work as intended - 7a9356b <7a9356b> refactor(navigation): improve error handling and input validation in navigateToApp - 02037ff <02037ff> paste created handle error logic - 040b3ba <040b3ba> paste created handle error logic - ce83f20 <ce83f20> added some compent and cross to run the project File Changes (30 files <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files>) - *M* omods/core/api/src/main/java/org/openmrs/module/icare/billing/BillingServiceImpl.java <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-24e9e405133e3a9317e63d01a0d37a93ec0123a8c2a16f97b3b95bd87a7506fb> (507) - *M* omods/core/api/src/main/java/org/openmrs/module/icare/billing/dao/PaymentDAO.java <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-75f3fcdcbe58ce729ec470e94fe86a62f4af90312bd3cafe86f57934b745ebbe> (2) - *A* omods/core/api/src/main/java/org/openmrs/module/icare/billing/models/CallbackData.java <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-12fe5bcce887fcf345bf98fcd3185b6868987f2ab79f83d9cc80622ae54465de> (166) - *A* omods/core/api/src/main/java/org/openmrs/module/icare/billing/models/RequestDto.java <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-5fdaee4c5ff2bb8696ce0fe86aadd206f5e980267a9c889fd3e95d81b5a5ea42> (30) - *M* omods/core/api/src/main/java/org/openmrs/module/icare/billing/services/BillingService.java <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-b6f8a332e08c98736af1d5cee97f39c0962eced83bdda70a875c7652d1687f72> (4) - *M* omods/core/api/src/main/java/org/openmrs/module/icare/billing/services/payment/gepg/BillSubmissionRequest.java <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-c340f521dc208df32d931a2e7ff775012c7a94845508dab55b1de3fa71f1110a> (28) - *M* omods/core/api/src/main/java/org/openmrs/module/icare/billing/services/payment/gepg/BillTrxInf.java <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-586c7866b760036cd301ee1a6191981acb0e9fb259d6fb602f935d6b9dc2c9c2> (4) - *M* omods/core/api/src/main/java/org/openmrs/module/icare/billing/services/payment/gepg/GEPGService.java <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-b27558509031d7277d6164700d47501c792aa11fb18b1e0a20ed0cd6006618a3> (35) - *M* omods/core/api/src/main/java/org/openmrs/module/icare/core/dao/ICareDao.java <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-2c69bfae8207e6bb6818b5f0a68abda722eda4c3f2c105bcbadcadc27ea368f5> (1) - *M* omods/core/api/src/main/java/org/openmrs/module/icare/core/impl/ICareServiceImpl.java <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-3221310609529aad811756d67b4ce98886282a744484f3a4d3f9bafae08c7770> (5) - *M* omods/core/omod/src/main/java/org/openmrs/module/icare/web/controller/GepgBillingController.java <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-49ab7a254becbdc3fbc3b525299e11c1387ca6b7bf4967651a35def0a7ebc9c6> (201) - *M* ui/package-lock.json <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-86dd4842508e2d279ac0a1b9a660d6494b53ee7ccf321d641c0421cb15202fa6> (21762) - *M* ui/src/app/app.component.ts <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-140db00e6f298dae867746ab5efd8338944a783e502610cf10b2e16785f44aa7> (1) - *M* ui/src/app/core/containers/modules/modules.component.ts <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-8f3d96591eb3fcc7e09505a262eec2ecade231617aeaa59448555232ba581adb> (173) - *M* ui/src/app/core/services/location.service.ts <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-74bfc133447073ba95579a4cc5274a142604551f08bb57c64d6ac60a6a4be695> (6) - *M* ui/src/app/modules/dispensing/pages/dispensing-patient-list/dispensing-patient-list.component.html <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-edf88c86da5aeefd512c56d176a806583123600aed943ac346f9baabf6598602> (8) - *M* ui/src/app/shared/components/clinical-notes/clinical-notes.component.ts <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-7c7efd94656f5585fe66174362e41231259613cbd3174e454554fbe2ebf384ed> (23) - *M* ui/src/app/shared/components/patient-list/patient-list.component.ts <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-bb6711d2de0bf45de4b1aa26ff13e335c33569dfa1f0f59da371841ff392d9b8> (5) - *M* ui/src/app/shared/components/patients-tabular-list/patients-tabular-list.component.ts <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-7bcf311ce5f4ca1a4d3b1668b098a130fa0c5ec255b91183ddf9dd8fe9faece5> (1) - *M* ui/src/app/shared/components/shared-patient-dashboard/shared-patient-dashboard.component.html <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-b5dad015c636ab8835feb82835265f8fde53abf75edd2dc630727294cf5ca3a8> (29) - *M* ui/src/app/shared/components/shared-patient-dashboard/shared-patient-dashboard.component.scss <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-89f79880cec28ef95aa0a1321e483e74658779452e75d5077f52104dbb54e266> (3) - *M* ui/src/app/shared/components/shared-patient-dashboard/shared-patient-dashboard.component.ts <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-4220931fa32ad44a406c668e1ecba816bde7fda05f3802717315b437b9f60184> (17) - *M* ui/src/app/shared/modules/form/components/field/field.component.html <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-7c9a2d6f43873b067f4f0a52d6c9599b98679b5de5fed381bcc760d89544d3cf> (8) - *M* ui/src/app/shared/modules/form/components/field/field.component.ts <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-48d5402f521e6683a6b313fd3e569ce36c38193a1032db6c6c3e0db351402251> (2) - *A* ui/src/app/shared/resources/global-setting/services/globalsetting.service.spec.ts <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-18a6aca692aa329d0aeab0c476259818001b5faaf77185c1285352f311972f57> (16) - *A* ui/src/app/shared/resources/global-setting/services/globalsetting.service.ts <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-960c9bbc28a62877acc9776a3827fd577baf3bf93e012cdeeb6a4a2ab9fa3dcf> (36) - *A* ui/src/app/shared/resources/global-setting/services/index.ts <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-eb9d4b8084b38922540a4d6c8d825db6b46b2f0982350bacd5bc4860b2f59e7e> (1) - *M* ui/src/app/shared/resources/visits/services/visits.service.ts <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-76b75ba75c587f6fdcb119c4623537d726cd487927a88f1ea84625ccb21f624a> (1) - *M* ui/src/app/shared/store-pages/issuing-page/issuing-page.component.html <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-66a2a5d921df6dfcf540819b51a9650524f647c7425201e2ba812bcc24a23a66> (2) - *M* ui/src/app/shared/store-pages/requisition-page/requisition-page.component.html <https://github.com/udsm-dhis2-lab/iCareConnect/pull/540/files#diff-5c3407859bb18592d997b1f3c55a5f5b83d5d154aee866ece064aae134974d25> (4) Patch Links: - https://github.com/udsm-dhis2-lab/iCareConnect/pull/540.patch - https://github.com/udsm-dhis2-lab/iCareConnect/pull/540.diff — Reply to this email directly, view it on GitHub <#540>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A2TLCLEYATW3LQVSBDYB3RL2LD5F7AVCNFSM6AAAAABVL35JDCVHI2DSMVQWIX3LMV43ASLTON2WKOZSG44TKNBSG42TMMA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>