Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html tags incorrectly applied in notice #680

Closed
ewsopp opened this issue Oct 5, 2023 · 2 comments
Closed

html tags incorrectly applied in notice #680

ewsopp opened this issue Oct 5, 2023 · 2 comments
Assignees
@balexey88
Labels
type/bug
Milestone
v3.2.5

Comments

@ewsopp
Copy link
Member

ewsopp commented Oct 5, 2023 •
edited
Loading

Also remove the comma after Please in the second sentence.

image image
@planv planv added this to the v3.2.5 milestone Oct 5, 2023
@planv planv added the type/bug label Oct 5, 2023
balexey88 added a commit that referenced this issue Oct 9, 2023
@balexey88
#680: fix HTML tags in messages
9be7e46
balexey88 added a commit that referenced this issue Oct 9, 2023
@balexey88
#680: fix HTML tags in messages
6e29700
@balexey88
Copy link
Contributor

I was not able to reproduce exactly the same issues. Tried WP version 6.2 as on the screenshots by also no luck.
Possibly there is some issue with the theme or plugin?

In general I looked through the source code for the possible issues, but it's hard to reproduce all the possible cases. I'll keep an eye on this in the future and fix if I notice something,

Made the following changes:

  • Fixed the message when plugin fails to load
  • Fixed the message regarding PHP requirements (it was checking for PHP 5.5)
  • Removed comma and <b> tags in the heading

Also remove the comma after Please in the second sentence.

This is how it looks on my testing env:
image

image

@balexey88 balexey88 mentioned this issue Oct 9, 2023
Merged
@planv planv mentioned this issue Oct 16, 2023
Merged
balexey88 added a commit that referenced this issue Oct 16, 2023
@balexey88
#680: rollback new PHP version check
b8eb9b5
balexey88 added a commit that referenced this issue Oct 16, 2023
@balexey88
#680: rollback new PHP version check
2791076
planv added a commit that referenced this issue Oct 16, 2023
@planv
Merge pull request #684 from udx/680-incorect-html-tags-in-messages
9363584 
#680: rollback new PHP version check
@planv
Copy link
Contributor

planv commented Oct 17, 2023

Fix was released with version 3.2.5
Closing the ticket.

@planv planv closed this as completed Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@balexey88 balexey88

Labels
type/bug
Projects
None yet
Milestone
v3.2.5
Development

No branches or pull requests
3 participants
@planv @ewsopp @balexey88