Develop anton #443
Develop anton #443
Conversation
lib/classes/compatibility/divi.php
Outdated
|
|
||
|
|
||
| // maybe disable the filter | ||
| add_filter('sanitize_file_name', array( $this, 'sanitize_file_name' ), 1); |
There was a problem hiding this comment.
You could have used stateless_skip_cache_busting filter instead. Returning true will short-circuit the randomize_filename function.
There was a problem hiding this comment.
Ok, I'll check that filter. But don't understand now what exactly will short-circuit. Can you give an example?
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah, I see now what you mean short-circuit. Will implement using that filter, thanks.
There was a problem hiding this comment.
@alimuzzaman I think there is some bug in this line https://github.com/wpCloud/wp-stateless/blob/a93638abe0d2ae5013e0c7f6f7155e8e101c0c33/lib/classes/class-utility.php#L80
It should return $filename but not $return. If you return $return then the result of the randomize_filename function will be 1 (casted from true)
Can you confirm this?
There was a problem hiding this comment.
Sorry, for the confusion. you should return unmodified $filename from the filter, not true. Then $return will become $filename.
I wrote like that so you can modify it from the filter if needed.
There was a problem hiding this comment.
Sorry, for the confusion. you should return unmodified $filename from the filter, not true. Then $return will become $filename.
I wrote like that so you can modify it from the filter.
Ok, makes sense. Better to keep it as is.
There was a problem hiding this comment.
I will add documentation in stateless_skip_cache_busting filter.
| * | ||
| * @return bool | ||
| */ | ||
| public static function isCallStackMatches( $callstack, $conditions ) { |
Includes issues: