make jti and aud required fields, since they are primary keys #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run |
doomspork
previously approved these changes
Feb 1, 2021
…db, add test to back it up
Hanspagh
force-pushed
the
test-db-failing
branch
from
e29fd7f to
7f292b1
Compare
|
Sorry for that, should be done now |
|
@Hanspagh can you rebase on master now that Github actions are in that branch? |
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
=======================================
Coverage 81.25% 81.25%
=======================================
Files 5 5
Lines 64 64
=======================================
Hits 52 52
Misses 12 12
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After seeing #120 I released we have to test that actually hit this case. So I decided to clean up the token module a bit up. I have changed
jtiandaudto be required fields since they are already primary keys and the insert actually hard fails if they are missing. Now we til hit ourtoken_storage_failure. Let me know what you think