Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated approval_prompt with prompt #51

Conversation

venkatd
Copy link
Contributor

@venkatd venkatd commented Apr 24, 2018

approval_prompt has been deprecated and no longer works. It has been replaced by the prompt option. You can see the list of parameters here:
https://developers.google.com/identity/protocols/OAuth2WebServer#creatingclient

In the future, it may be worth considering an alternate strategy of just passing through all options directly so a code update isn't necessary every time the options change.

Resolves #49 and is the same as #50 except it renames prompt to approval_prompt because the later is no longer honored by Google's OAuth.

@venkatd
Copy link
Contributor Author

venkatd commented Apr 24, 2018

Looks like travis doesn't recognize this as an elixir project. I can include a travis.yml if desired.

@doomspork doomspork merged commit 5a79321 into ueberauth:master Apr 25, 2018
@doomspork
Copy link
Member

@venkatd if you're interested in contributions a .travis.yml would be greatly appreciated. In fact, we need one for every provider project 😰

@pyromaniac
Copy link

pyromaniac commented Apr 25, 2018

This is awesome, thanks for the follow-up! Any chance for the next release to be done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants