Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function noStandalone to disable --standalone #64

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

mejo-
Copy link
Contributor

@mejo- mejo- commented Jan 28, 2023

This implementation keeps backwards-compability by adding --standalone in run() per default but not adding it per default in execute().

It still can be set explicitely with standalone(), resulting in execute() passing --standalone.

Additionally it can be disabled explicitely with noStandalone(), resulting in run() not passing --standalone.

Fixes: #31

Signed-off-by: Jonas jonas@freesources.org

This implementation keeps backwards-compability by adding `--standalone`
in `run()` per default but not adding it per default in `execute()`.

It still can be set explicitely with `standalone()`, resulting in
`execute()` passing `--standalone`.

Additionally it can be disabled explicitely with `noStandalone()`,
resulting in `run()` not passing `--standalone`.

Fixes: ueberdosis#31

Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
Copy link
Contributor Author

mejo- commented Feb 27, 2023

Any chance to get this merged @patrickbaber @hanspagel?

@patrickbaber patrickbaber merged commit c5f16d5 into ueberdosis:main Feb 28, 2023
@mejo-
Copy link
Contributor Author

mejo- commented Mar 4, 2023

Thanks a lot for merging and building a new release straight away ❤️

@patrickbaber
Copy link
Contributor

You are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"standalone" should not be forced
2 participants